From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Phil Sainty Newsgroups: gmane.emacs.bugs Subject: bug#31446: 26.1; sql-interactive-mode buffer naming is broken Date: Tue, 22 May 2018 10:08:05 +1200 Message-ID: <51c17257ab43917d561cc5e56a556d67@webmail.orcon.net.nz> References: <83d0xti993.fsf@gnu.org> <83bmddi2ad.fsf@gnu.org> <83603lhrvw.fsf@gnu.org> <8336yoiuf4.fsf@gnu.org> <831se6hjnh.fsf@gnu.org> <83h8n1g2hm.fsf@gnu.org> <42fe26038dde2b56636888cfbf4e37bb@webmail.orcon.net.nz> <83603hf1w9.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1526940429 17513 195.159.176.226 (21 May 2018 22:07:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 21 May 2018 22:07:09 +0000 (UTC) User-Agent: Orcon Webmail Cc: 31446@debbugs.gnu.org, fgunbin@fastmail.fm, bug-gnu-emacs-bounces+psainty=orcon.net.nz@gnu.org, michael@mauger.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue May 22 00:07:04 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fKsxK-0004Lz-2Z for geb-bug-gnu-emacs@m.gmane.org; Tue, 22 May 2018 00:07:02 +0200 Original-Received: from localhost ([::1]:52652 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fKszQ-0000Wx-Mt for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 May 2018 18:09:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44765) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fKszK-0000Ws-45 for bug-gnu-emacs@gnu.org; Mon, 21 May 2018 18:09:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fKszG-00031a-2c for bug-gnu-emacs@gnu.org; Mon, 21 May 2018 18:09:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35426) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fKszF-00031T-Uf for bug-gnu-emacs@gnu.org; Mon, 21 May 2018 18:09:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fKszF-0004Rr-Ju for bug-gnu-emacs@gnu.org; Mon, 21 May 2018 18:09:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Phil Sainty Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 May 2018 22:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31446 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31446-submit@debbugs.gnu.org id=B31446.152694049117043 (code B ref 31446); Mon, 21 May 2018 22:09:01 +0000 Original-Received: (at 31446) by debbugs.gnu.org; 21 May 2018 22:08:11 +0000 Original-Received: from localhost ([127.0.0.1]:43323 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fKsyQ-0004Qp-Mm for submit@debbugs.gnu.org; Mon, 21 May 2018 18:08:10 -0400 Original-Received: from smtp-2.orcon.net.nz ([60.234.4.43]:56142) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fKsyO-0004Qh-OJ for 31446@debbugs.gnu.org; Mon, 21 May 2018 18:08:09 -0400 Original-Received: from [10.253.37.70] (port=38495 helo=webmail.orcon.net.nz) by smtp-2.orcon.net.nz with esmtpa (Exim 4.86_2) (envelope-from ) id 1fKsyL-0001fB-MM; Tue, 22 May 2018 10:08:05 +1200 Original-Received: from wlgwil-nat-office.catalyst.net.nz ([202.78.240.7]) via [10.253.37.253] by webmail.orcon.net.nz with HTTP (HTTP/1.1 POST); Tue, 22 May 2018 10:08:05 +1200 In-Reply-To: <83603hf1w9.fsf@gnu.org> X-Sender: psainty@orcon.net.nz X-GeoIP: -- X-Spam_score: -2.9 X-Spam_score_int: -28 X-Spam_bar: -- X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:146360 Archived-At: On 2018-05-22 03:45, Eli Zaretskii wrote: > Thanks, I tried fixing it in a slightly different way, please take a > look. I'd like to avoid releasing Emacs 26.1 with sql.el that was > broken by latest changes. That seems to work, except for regressing this bit: >> I *think* we'd want (consp new-name) for that test (especially as >> it ought to cover multiple uses of C-u) With C-u C-u M-x sql-postgres I end up with buffer name "*SQL: (16)*" and "Process SQL: (16) finished" etc. Another difference from Emacs 25 is that using a prefix arg in Emacs 25 was guaranteed to create a new buffer/process (if the chosen buffer name conflicted then it was uniquified), whereas the new code is switching to the pre-existing buffer in the situation. Calling `sql-rename-buffer' handles uniquification, and my suggested code seems to be consistent with the old behaviour. Hopefully Filipp (or others) can do some testing as well -- I've not been as thorough as I would like, so it would be good to have others verifying the changes too. -Phil As a side-note, I've just observed that killing SQLi buffers from the `list-buffers' buffer triggers "error in process sentinel: Selecting deleted buffer" after confirming that the process should be killed (which prevents marking and killing *multiple* such buffers). I see this also happens in Emacs 25, however.