From: "Mattias Engdegård" <mattias.engdegard@gmail.com>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: Ruijie Yu <ruijie@netyu.xyz>, Eli Zaretskii <eliz@gnu.org>,
61730@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#61730: 30.0.50; Compiler warnings for delq and delete
Date: Sun, 21 May 2023 10:42:30 +0200 [thread overview]
Message-ID: <45A710C9-FE43-4647-A31D-8B4CE533D6D0@gmail.com> (raw)
In-Reply-To: <87ttw6xrno.fsf@web.de>
21 maj 2023 kl. 05.57 skrev Michael Heerdegen <michael_heerdegen@web.de>:
>> Maybe we can take inspirations from other langagues? In rust we have
>> the `#[must_use]' attribute [1], and in C++17 and C23 we have the
>> `[[nodiscard]]' attribute [2] [3].
>
> These are not bad. I like "nodiscard".
There are probably better names than the chosen one but I went back and forth on it for a while so we should let it sink in for a bit before switching again. There is still some time before the release of Emacs 30.
>> Also, is there any definitive relation between this
>> 'important-return-value property and the existing "pure" function
>> declaration? Like the `(declare (pure t))' thing in the front of a
>> defun.
>
> Interesting question. Does 'pure' (or 'side-effect-free') imply
> 'important-return-value'?
Not `pure`, but (almost) all functions declared `pure` are also `side-effect-free` (possibly error-free).
`side-effect-free` often produces the same warning as `important-return-value` for calls that don't use the return value, but the entire call can be deleted silently under some circumstances.
21 maj 2023 kl. 07.55 skrev Eli Zaretskii <eliz@gnu.org>:
> no-discard-value, I hope. Just "nodiscard" is too terse (discard
> what?).
I agree, we should prefer more descriptive names. Let's see what we can come up with.
next prev parent reply other threads:[~2023-05-21 8:42 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 10:29 bug#61730: 30.0.50; Compiler warnings for delq and delete Michael Heerdegen
2023-02-24 3:59 ` Richard Stallman
2023-02-24 13:43 ` Mattias Engdegård
2023-02-24 13:56 ` Eli Zaretskii
2023-02-24 15:11 ` Michael Heerdegen
2023-02-24 15:29 ` Eli Zaretskii
2023-02-24 15:45 ` Michael Heerdegen
2023-02-24 15:48 ` Eli Zaretskii
2023-02-24 16:17 ` Michael Heerdegen
2023-02-24 16:45 ` Michael Heerdegen
2023-02-24 19:33 ` Mattias Engdegård
2023-02-24 20:20 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-25 9:40 ` Mattias Engdegård
2023-02-25 4:15 ` Richard Stallman
2023-02-25 8:11 ` Eli Zaretskii
2023-02-25 12:34 ` Michael Heerdegen
2023-02-25 13:25 ` Eli Zaretskii
2023-02-25 15:09 ` Michael Heerdegen
2023-02-25 15:29 ` Michael Heerdegen
2023-02-25 15:48 ` Eli Zaretskii
2023-02-27 3:22 ` Richard Stallman
2023-02-27 10:37 ` Michael Heerdegen
2023-02-27 11:37 ` Eli Zaretskii
2023-02-27 3:24 ` Richard Stallman
2023-02-27 11:44 ` Eli Zaretskii
2023-02-24 15:52 ` Mattias Engdegård
2023-02-24 16:37 ` Michael Heerdegen
2023-04-09 16:41 ` Mattias Engdegård
2023-05-01 16:06 ` Mattias Engdegård
2023-05-20 1:57 ` Michael Heerdegen
2023-05-20 9:14 ` Mattias Engdegård
2023-05-21 0:56 ` Michael Heerdegen
2023-05-21 3:01 ` Ruijie Yu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-21 3:57 ` Michael Heerdegen
2023-05-21 5:55 ` Eli Zaretskii
2023-05-21 8:42 ` Mattias Engdegård [this message]
2023-05-31 14:38 ` Mattias Engdegård
2023-06-01 0:48 ` Michael Heerdegen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45A710C9-FE43-4647-A31D-8B4CE533D6D0@gmail.com \
--to=mattias.engdegard@gmail.com \
--cc=61730@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=michael_heerdegen@web.de \
--cc=monnier@iro.umontreal.ca \
--cc=ruijie@netyu.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).