From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#61730: 30.0.50; Compiler warnings for delq and delete Date: Sun, 21 May 2023 10:42:30 +0200 Message-ID: <45A710C9-FE43-4647-A31D-8B4CE533D6D0@gmail.com> References: <87ednbdatj.fsf@web.de> <12EE2A5E-A357-4186-9B81-27A65DE9A3DF@gmail.com> <874jo6cxim.fsf@web.de> <87ttw6xrno.fsf@web.de> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27970"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Ruijie Yu , Eli Zaretskii , 61730@debbugs.gnu.org, Stefan Monnier To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 21 10:43:14 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q0eeo-00079X-KZ for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 May 2023 10:43:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q0eee-0006R8-2o; Sun, 21 May 2023 04:43:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q0eec-0006Qz-JZ for bug-gnu-emacs@gnu.org; Sun, 21 May 2023 04:43:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q0eec-0001zG-BK for bug-gnu-emacs@gnu.org; Sun, 21 May 2023 04:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q0eec-0002pA-79 for bug-gnu-emacs@gnu.org; Sun, 21 May 2023 04:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 May 2023 08:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61730 X-GNU-PR-Package: emacs Original-Received: via spool by 61730-submit@debbugs.gnu.org id=B61730.168465856210830 (code B ref 61730); Sun, 21 May 2023 08:43:02 +0000 Original-Received: (at 61730) by debbugs.gnu.org; 21 May 2023 08:42:42 +0000 Original-Received: from localhost ([127.0.0.1]:59996 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q0eeI-0002ob-2E for submit@debbugs.gnu.org; Sun, 21 May 2023 04:42:42 -0400 Original-Received: from mail-lf1-f53.google.com ([209.85.167.53]:47122) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q0eeE-0002oK-40 for 61730@debbugs.gnu.org; Sun, 21 May 2023 04:42:40 -0400 Original-Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-4f3af4295ddso2315675e87.2 for <61730@debbugs.gnu.org>; Sun, 21 May 2023 01:42:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684658552; x=1687250552; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=jmxcolUvDf4oMe0sxxZJj9K+IVfbfo2xzCP1fNxUZ24=; b=gqadHfhFXFoi43AbbaYg98NX38yUkUr9FppgUhwr0vw0iZM/FG/hhemSKOBk0pbmXs CZtrwcS5iPFfl05Hx+147lbFuoM2wF21PW4qnKZk962tWtPWp3gwaoiiCQb0VAEDt3pb bAdb5T63LEDmSK+7QvnLjFXwFNX3grT/XyD/7XO1USWmJcxq59aFA7DNE6M1qUFb9Juy TNho3GOXeLuEafH/oSp9V1xo2rCTZBC7bLsXKd0AuC36Uop/ovQ+Tk0A0vfV840uL7hu hAaRYICzfYhkNiHdIGG2MTS8jMF/zum/C229CQIELbYi+rcGiBfD92ImDOtNMGH68YcU 7dLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684658552; x=1687250552; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=jmxcolUvDf4oMe0sxxZJj9K+IVfbfo2xzCP1fNxUZ24=; b=RqopdPxTDgf2ZVq8ZtKSkezxFnnpaTr4ENCJJ+mMCPZGQYYymVr/yq0JUUJuPgNJAG Mk7bSw5WgmcP+/tAn6qi/tYfJKhewkRoWmdUuau21feR1YBXwCE5k4ksgLtkdJTRZb0R /MpyI5vehMy4meSoo6MTGo0oz6GB6wB8GnkC+ZmvlxIo1NMIttfzgH8XN2YKgcmpypsU 79wYD6c6n6g7iyGXvoP+DYfzxDTjsVoD6BbKaUYbCal/65Jb2JGVj1v8tue/2Disq9mH I3MZlqo54gC2S+ytbdWuHKMPRVSXA5FMrkYkFnScu3PZHZZvCYO4VjI0zdTF3Ai6oDYO CyOA== X-Gm-Message-State: AC+VfDwr5R2RftLjJREeSPp0y0LEB6rNpoGB0kroXHZh3L2AXm1M6TRf OALCes+l+C5aWsHT/LDKEN8= X-Google-Smtp-Source: ACHHUZ7GJZwlYzygXSkOMh5es6u62P23SyYNOIofbpu+8ne3zk1YgfrS+5PIr3e2JZk7Uy9p2BNF/A== X-Received: by 2002:ac2:5973:0:b0:4f3:98b4:e45a with SMTP id h19-20020ac25973000000b004f398b4e45amr2275386lfp.21.1684658551740; Sun, 21 May 2023 01:42:31 -0700 (PDT) Original-Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id v3-20020ac25603000000b004f138c4de81sm546886lfd.149.2023.05.21.01.42.30 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 21 May 2023 01:42:31 -0700 (PDT) In-Reply-To: <87ttw6xrno.fsf@web.de> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262097 Archived-At: 21 maj 2023 kl. 05.57 skrev Michael Heerdegen = : >> Maybe we can take inspirations from other langagues? In rust we have >> the `#[must_use]' attribute [1], and in C++17 and C23 we have the >> `[[nodiscard]]' attribute [2] [3]. >=20 > These are not bad. I like "nodiscard". There are probably better names than the chosen one but I went back and = forth on it for a while so we should let it sink in for a bit before = switching again. There is still some time before the release of Emacs = 30. >> Also, is there any definitive relation between this >> 'important-return-value property and the existing "pure" function >> declaration? Like the `(declare (pure t))' thing in the front of a >> defun. >=20 > Interesting question. Does 'pure' (or 'side-effect-free') imply > 'important-return-value'? Not `pure`, but (almost) all functions declared `pure` are also = `side-effect-free` (possibly error-free). `side-effect-free` often produces the same warning as = `important-return-value` for calls that don't use the return value, but = the entire call can be deleted silently under some circumstances. 21 maj 2023 kl. 07.55 skrev Eli Zaretskii : > no-discard-value, I hope. Just "nodiscard" is too terse (discard > what?). I agree, we should prefer more descriptive names. Let's see what we can = come up with.