From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#47286: 28.0.50; [PATCH] Replace "(default %s)" with 'format-prompt' Date: Sun, 21 Mar 2021 20:57:04 +0200 Message-ID: <2454249f-5987-8f04-a58e-0596f572bb0e@yandex.ru> References: <87o8fc1p1q.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22787"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 To: Gabriel , 47286@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 21 19:58:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lO3H7-0005pN-F8 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 Mar 2021 19:58:09 +0100 Original-Received: from localhost ([::1]:48798 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lO3H6-0007x2-GY for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 Mar 2021 14:58:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54264) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lO3H0-0007wr-E5 for bug-gnu-emacs@gnu.org; Sun, 21 Mar 2021 14:58:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43954) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lO3H0-0006Zi-67 for bug-gnu-emacs@gnu.org; Sun, 21 Mar 2021 14:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lO3H0-00072o-5H for bug-gnu-emacs@gnu.org; Sun, 21 Mar 2021 14:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Mar 2021 18:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47286 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 47286-submit@debbugs.gnu.org id=B47286.161635303527015 (code B ref 47286); Sun, 21 Mar 2021 18:58:02 +0000 Original-Received: (at 47286) by debbugs.gnu.org; 21 Mar 2021 18:57:15 +0000 Original-Received: from localhost ([127.0.0.1]:55500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lO3GF-00071f-H4 for submit@debbugs.gnu.org; Sun, 21 Mar 2021 14:57:15 -0400 Original-Received: from mail-wr1-f48.google.com ([209.85.221.48]:39693) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lO3GC-00071N-Bt for 47286@debbugs.gnu.org; Sun, 21 Mar 2021 14:57:14 -0400 Original-Received: by mail-wr1-f48.google.com with SMTP id e18so14439642wrt.6 for <47286@debbugs.gnu.org>; Sun, 21 Mar 2021 11:57:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=aYwj0XvP9mfCO5TcQIkblQpvVMn6cHgwCEWV5FBATvY=; b=oZNrrcdcpbvsI+gyZzwtwY7ZaLTpfa+PsNBUdl//EW4r6qnlTqzbrsN9m0Pxq936D/ eGBwDHSMO2QWWjS9FklkJBlcU53P7CSFge08apYsy4KZ2e0nky6SLxBsQHpaShuScWLK GhTiJvtkq6mTfYLMAPXuCC2bHQSyYuCtQE84K6dhOqfB+RkdcmSaHHa2VyCmdhIFrNKb 54/iTPMzm6rHmPx6xwcKRzCbABCWmZsthiB90HvmYl+rhnyggKkAX9HPkb4hLn1psWtk iry+OcFivBkqR2uFQrz4PyM7ACDxj4XUYDDcbaUCz4fcdWyDrbBAFtwtv6StUSvqSJwl vxcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=aYwj0XvP9mfCO5TcQIkblQpvVMn6cHgwCEWV5FBATvY=; b=RcnvSC1VxHiL0KXPLop4KDNmygkN7GwoozlYMIwjJd8eBv2SL/qn+lmGqo0noZw97t EEIa2/TyOkMqVBY7NaoTna7vePn3XKJaeXHHS2EHH4WIn94cQ7a7VqNxytrpLdse8J35 y4i45KEvHQYsMnAxNi0Wdhi3hGOB4qzg4XOQIFs9ko2lAyT6P7BPAN+g7wnIQEiqD55T 6NKX0xSoJ5TgF8unpv84TFVnk3OOrWT3GflHDhN7Jks2t4dd2lHuzNy0Q5yqtpvhBCff CAd5fYavKrGqRqpTMnr0Dz+21Mi20NhOF6XD8vDdK0LlvLKO2KYpfu7N/aXf81uqcof0 pwtw== X-Gm-Message-State: AOAM530JlJqnz1oFR0Z2V49nZksJJRA9aPJR8C5RUAIHK55PNRplJs1B 5cMD0DfLzF/pjaEch5y6+8NYAwwAKdE= X-Google-Smtp-Source: ABdhPJzF4hYei8GXCcaVzreQN7yoHQrxIsIPPDb8NAoxu5S/DnKgB9WiVTduMy9RWOl4ZyhovfAxFg== X-Received: by 2002:a5d:560e:: with SMTP id l14mr14584147wrv.10.1616353026459; Sun, 21 Mar 2021 11:57:06 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id p6sm16433995wru.2.2021.03.21.11.57.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 21 Mar 2021 11:57:06 -0700 (PDT) In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:202801 Archived-At: On 21.03.2021 20:31, Gabriel wrote: > Thanks for pointing it out. I just searched for the current source tree > of master branch for ocurrences of "(default %s)", so I am not sure if I > changed some package that shouldn't be update. If so, I will promptly > update the patch. > > Perhaps project.el could use a similar fallback that exists on > cperl-mode.el (commit 3a95f4fc12df0a570ad413e099a22bf901b7346d): > > ;; Available in Emacs 28: format-prompt > (defalias 'cperl--format-prompt > (if (fboundp 'format-prompt) 'format-prompt > (lambda (msg default) > (if default (format "%s (default %s): " msg default) > (concat msg ": "))))) Sounds reasonable to me. Also note that project--completing-read-strict includes as (string-equal default "") check added in 2be537e64. Perhaps format-prompt could use it as well.