From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#47832: 28.0.50; define-fringe-bitmap and emacs --daemon Date: Sat, 17 Apr 2021 09:49:46 +0000 Message-ID: <1869622e16688e6aedec@heytings.org> References: <7dee3f4235cf450a3254@heytings.org> <83mttxwgm8.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="wSN0riL65Y" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19910"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 47832@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 17 11:50:30 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lXhav-00055g-7z for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Apr 2021 11:50:29 +0200 Original-Received: from localhost ([::1]:39308 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lXhas-0003ki-TB for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Apr 2021 05:50:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52340) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lXhaT-0003kb-SN for bug-gnu-emacs@gnu.org; Sat, 17 Apr 2021 05:50:01 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59005) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lXhaT-0000x2-Kz for bug-gnu-emacs@gnu.org; Sat, 17 Apr 2021 05:50:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lXhaT-0000LO-IQ for bug-gnu-emacs@gnu.org; Sat, 17 Apr 2021 05:50:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Apr 2021 09:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47832 X-GNU-PR-Package: emacs Original-Received: via spool by 47832-submit@debbugs.gnu.org id=B47832.16186529911302 (code B ref 47832); Sat, 17 Apr 2021 09:50:01 +0000 Original-Received: (at 47832) by debbugs.gnu.org; 17 Apr 2021 09:49:51 +0000 Original-Received: from localhost ([127.0.0.1]:42318 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXhaI-0000Kv-Ts for submit@debbugs.gnu.org; Sat, 17 Apr 2021 05:49:51 -0400 Original-Received: from heytings.org ([95.142.160.155]:41468) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lXhaF-0000Kk-Rc for 47832@debbugs.gnu.org; Sat, 17 Apr 2021 05:49:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1618652986; bh=+miRQ7Cjg3t1J0eTsPnUaOiFqSOWlgSGEyLqBUCoeD0=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=EipFU2F8cBTcY1VBLrW1taCRlI7Ij8C2XGWRlSjd0IKF2UeVvBhASvCjmZhWg8Aqr hQM8Mb0mtaDrOiofRoJ5tUYXSox4DbpfSsscgP4O6/i4AYmorbRYX/PVcUXlkqUbzW 2yic/46ScqDPch6d/QP8697OZIQjoZW6JU1Rh35kKPNwSHbYwcjSfUcOJ1x5QqHW6Y KENmNuRSi0oa5wCQO8XHnm+VYqLt3BsnnR3CgR1oOniNXvSQUEpyggEJpjbcvhL/XR MKf4D9gbx5ct8AjbWoBvNUuor91Pj3exU0sz/TLGyeGsxNvlngonhHTnhWWmuB84Ew 2LZYHg+kiFZDQ== In-Reply-To: <83mttxwgm8.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:204183 Archived-At: --wSN0riL65Y Content-Type: text/plain; format=flowed; charset=us-ascii > > However, if this used to work, > This used to work indeed; it worked on GNU/Linux with default (non-Cairo) builds for Emacs 24 to 27. > > it would be good to understand which change broke it. > Got it! :-) The commit I identified is indeed the culprit. With USE_CAIRO, gui_init_fringe() is called in x_initialize(); without USE_CAIRO it isn't. And gui_init_fringe() had a bug, which should now be fixed on Windows, too. Patch attached. --wSN0riL65Y Content-Type: text/x-diff; name=Consider-all-user-defined-bitmaps-in-gui_init_fringe.patch Content-Transfer-Encoding: base64 Content-ID: <1869622e1674b457f9ca@heytings.org> Content-Description: Content-Disposition: attachment; filename=Consider-all-user-defined-bitmaps-in-gui_init_fringe.patch RnJvbSA0ZDVhMThiYmIxODQ5NmViMDJlOTQ5Yjk5M2NjM2Y5YmNhN2M0ZDkx IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQ0KRnJvbTogR3JlZ29yeSBIZXl0 aW5ncyA8Z3JlZ29yeUBoZXl0aW5ncy5vcmc+DQpEYXRlOiBTYXQsIDE3IEFw ciAyMDIxIDA5OjM3OjIxICswMDAwDQpTdWJqZWN0OiBbUEFUQ0hdIENvbnNp ZGVyIGFsbCB1c2VyLWRlZmluZWQgYml0bWFwcyBpbiBndWlfaW5pdF9mcmlu Z2UoKQ0KDQoqIHNyYy9mcmluZ2UuYyAoZ3VpX2luaXRfZnJpbmdlKTogQWxz byBjb25zaWRlciB1c2VyLWRlZmluZWQgYml0bWFwcyB0aGF0DQpvdmVycmlk ZSBkZWZhdWx0IG9uZXMgKEJ1ZyM0NzgzMikuDQotLS0NCiBzcmMvZnJpbmdl LmMgfCAyICstDQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAx IGRlbGV0aW9uKC0pDQoNCmRpZmYgLS1naXQgYS9zcmMvZnJpbmdlLmMgYi9z cmMvZnJpbmdlLmMNCmluZGV4IDY1YzlhODRhYzkuLmYyYjYwYjVjOGUgMTAw NjQ0DQotLS0gYS9zcmMvZnJpbmdlLmMNCisrKyBiL3NyYy9mcmluZ2UuYw0K QEAgLTE3ODMsNyArMTc4Myw3IEBAIGd1aV9pbml0X2ZyaW5nZSAoc3RydWN0 IHJlZGlzcGxheV9pbnRlcmZhY2UgKnJpZikNCiAgICAgIGJlZm9yZSB0aGUg ZnJhbWUgb2YgdGhpcyBraW5kIHdhcyBpbml0aWFsaXplZC4gIFRoaXMgY2Fu IGhhcHBlbg0KICAgICAgaWYgRW1hY3MgaXMgc3RhcnRlZCBhcyBhIGRhZW1v biBhbmQgdGhlIGluaXQgZmlsZXMgZGVmaW5lIGZyaW5nZQ0KICAgICAgYml0 bWFwcy4gICovDQotICBmb3IgKCA7IGJ0IDwgbWF4X3VzZWRfZnJpbmdlX2Jp dG1hcDsgYnQrKykNCisgIGZvciAoYnQgPSBOT19GUklOR0VfQklUTUFQICsg MTsgYnQgPCBtYXhfdXNlZF9mcmluZ2VfYml0bWFwOyBidCsrKQ0KICAgICB7 DQogICAgICAgc3RydWN0IGZyaW5nZV9iaXRtYXAgKmZiID0gZnJpbmdlX2Jp dG1hcHNbYnRdOw0KICAgICAgIGlmIChmYikNCi0tIA0KMi4zMC4yDQoNCg== --wSN0riL65Y--