From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#44420: 28.0.50; vc-register, under vc-dir buffer, says file already registered Date: Sun, 8 Nov 2020 04:25:37 +0200 Message-ID: <10f619e6-c82c-54dc-133c-4fe8306c8db3@yandex.ru> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29833"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 Cc: 44420@debbugs.gnu.org To: Pankaj Jangid , Andrii Kolomoiets Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 08 03:26:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kbaPB-0007ed-EC for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 08 Nov 2020 03:26:09 +0100 Original-Received: from localhost ([::1]:49824 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kbaPA-0005zW-Fv for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 Nov 2020 21:26:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50976) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kbaP4-0005zH-7E for bug-gnu-emacs@gnu.org; Sat, 07 Nov 2020 21:26:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47971) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kbaP3-0001ji-UL for bug-gnu-emacs@gnu.org; Sat, 07 Nov 2020 21:26:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kbaP3-00087Q-Qd for bug-gnu-emacs@gnu.org; Sat, 07 Nov 2020 21:26:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Nov 2020 02:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44420 X-GNU-PR-Package: emacs Original-Received: via spool by 44420-submit@debbugs.gnu.org id=B44420.160480234831189 (code B ref 44420); Sun, 08 Nov 2020 02:26:01 +0000 Original-Received: (at 44420) by debbugs.gnu.org; 8 Nov 2020 02:25:48 +0000 Original-Received: from localhost ([127.0.0.1]:59517 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kbaOp-00086z-TI for submit@debbugs.gnu.org; Sat, 07 Nov 2020 21:25:48 -0500 Original-Received: from mail-ej1-f41.google.com ([209.85.218.41]:39412) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kbaOn-00086m-TX for 44420@debbugs.gnu.org; Sat, 07 Nov 2020 21:25:46 -0500 Original-Received: by mail-ej1-f41.google.com with SMTP id s25so7348390ejy.6 for <44420@debbugs.gnu.org>; Sat, 07 Nov 2020 18:25:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=FeAJQ5Ev+w0dDEqsvMccYbej+GIbcKvh8aDQURnB3Ws=; b=jSUh8Cfx3wPpwPYFXWgewdCqUcKqnASu1G1BQL6fqVmWhDyjLo+OLRSo7y3sj4nueS 5q1gEPIL50MjxxfyhQwgZVrLhQ4fupZm2zzGyPV4nAYhkgSRx+AfwFKynjMesU8EbaTJ brpHYu8/j7NKPX9pbJdMl0ssKnG7Ws34P9uBsSvQnxe+AXobdM1GIvJV/PngY0y/Jux2 1jECQiDBj57sqpbiXtWpkUJDx40y6sWWLKpwSBthkUWj8kG8MEpU+rpLHS8Zyj8HS1xr 3NW77pyuzBpyuFHvedJOF0gffItaMRq6IgK+tpgvHxGxi/rTQlFkG3DvIo0sYqfzThLj KYlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=FeAJQ5Ev+w0dDEqsvMccYbej+GIbcKvh8aDQURnB3Ws=; b=TG9AYhjIVZucysXkcnun+RtvLW5EbuXsrswUNivo63onlBsgGNo+C691YZYOUyvUtL DqecASzC3t/V7HCblu7pTEQz4Gd+UVJ8NPq3++F90heVFqgJQ2HvSAt4y2OvbGi8VZjI 5Wu9VsVrmd3KSHgWX0iyRM1JNuQ7+lgEtPAeCdOCyvJKRvpGPrIdy9TXRCYhklUmEyor UZ4tHzp1xlWTCO2+RkEbIzwD8WmIWIXCT6CQQ2nfKn0/813+onc3k/Zi/B9T+FimE+Vx TTsn9Q7mqMavBZYpJu99e6GlCQ/HcElqWUFxt32vCVY7yyvF20RR/1zu6xNaFp02xXgr colw== X-Gm-Message-State: AOAM532n/K8vjA+QXf7PgoH9PBwBAMavzXfbstvoKGSoVve0vP25p30u xsGcgBsGWWS2HRw1MUUa6Y45pyKa7Rfc6g== X-Google-Smtp-Source: ABdhPJwjNAugJ7v69N9pbMMd/z/P+F66TSb699CVuo0Qq62cmd1t0dmr8fdy8xEUCbhWPFYcHWaBSw== X-Received: by 2002:a17:906:604e:: with SMTP id p14mr9454061ejj.515.1604802339733; Sat, 07 Nov 2020 18:25:39 -0800 (PST) Original-Received: from [192.168.0.4] ([66.205.71.3]) by smtp.googlemail.com with ESMTPSA id l16sm4683261ejd.70.2020.11.07.18.25.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 07 Nov 2020 18:25:39 -0800 (PST) In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192858 Archived-At: On 05.11.2020 12:32, Pankaj Jangid wrote: >>>> Including file name in the "File already registered" message may help to >>>> understand whats going on though. >>> This could be a long list. We can just say "Marked file(s) already >>> registered". >> Files in the list are checked one by one and error is returned for the >> first registered file. IMO filename will fit well in the error message. > Yes one filename will definitely fit. Does this work for y'all? diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index 8def7da377..32664bcd25 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -1391,7 +1391,7 @@ vc-register (unless fname (setq fname buffer-file-name)) (when (vc-call-backend backend 'registered fname) - (error "This file is already registered")) + (error "This file is already registered: %s" fname)) ;; Watch out for new buffers of size 0: the corresponding file ;; does not exist yet, even though buffer-modified-p is nil. (when bname