Re: [PATCH] org-agenda tag completion works with ido

[Nathaniel Flath <flat0103@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1114 bytes --]

New patch attached.

I have already signed the FSF copyright papers, so I haven't marked as
TINYCHANGE - let me know if I still should.

On Thu, Jul 13, 2017 at 4:31 PM, Kyle Meyer <kyle@kyleam.com> wrote:
> Nathaniel Flath <flat0103@gmail.com> writes:
>
>> I suppose so.  I still think this is a correct patch, since it doesn't
>> make sense to filter for non-existent tags.
>
> I agreed that require-match should be t earlier in the thread, but it
> turns out that that's not the source of your issue.  I took time to
> clarify this in order to a) help you solve your ido completion issue
> everywhere, not just one specific case in one particular package, and b)
> make the description in your commit message accurate, which it currently
> isn't.
>
> Feel free to send a new patch with an updated commit message.  Also,
> based on the contributor list [*], you should mark it with a TINYCHANGE
> cookie.  It looks like you're hitting up against your TINYCHANGE code
> limit, so please consider signing FSF copyright papers for future
> patches.
>
> [*] http://orgmode.org/worg/org-contribute.html
>
> --
> Kyle

[-- Attachment #2: 0001-completing-read-in-org-agenda-filter-by-tag-only-acc.patch --]
[-- Type: application/octet-stream, Size: 1040 bytes --]

From af4fe22c962aa83e039c4bb8611c0e9b9d7f7e19 Mon Sep 17 00:00:00 2001
From: Nathaniel Flath <flat0103@gmail.com>
Date: Wed, 12 Jul 2017 17:15:04 -0700
Subject: [PATCH] completing-read in org-agenda-filter-by-tag only accepts
 valid tags.

* org-agenda.el:
(org-agenda-filter-by-tag): pass t to require-match argument of completing-read.
This causes emacs to accept the full tag name when entering a prefix of one.
---
 lisp/org-agenda.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 9ac4f6583..20d128d0d 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -7496,7 +7496,7 @@ also press `-' or `+' to switch between filtering and excluding."
 		    (org-global-tags-completion-table)))
       (let ((completion-ignore-case t))
 	(setq tag (completing-read
-		   "Tag: " org-global-tags-completion-table))))
+		   "Tag: " org-global-tags-completion-table nil t))))
     (cond
      ((eq char ?\r)
       (org-agenda-filter-show-all-tag)
-- 
2.11.0 (Apple Git-81)