emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: Nathaniel Flath <flat0103@gmail.com>
Cc: org-mode List <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] org-agenda tag completion works with ido
Date: Thu, 13 Jul 2017 16:31:13 -0400	[thread overview]
Message-ID: <87wp7ccc4u.fsf@kyleam.com> (raw)
In-Reply-To: <CAPrg3HA+STN07LFjOnYGgJRrZs1ik2HHNGbt5X8zX3tfvU4Ebw@mail.gmail.com>

Nathaniel Flath <flat0103@gmail.com> writes:

> I suppose so.  I still think this is a correct patch, since it doesn't
> make sense to filter for non-existent tags.

I agreed that require-match should be t earlier in the thread, but it
turns out that that's not the source of your issue.  I took time to
clarify this in order to a) help you solve your ido completion issue
everywhere, not just one specific case in one particular package, and b)
make the description in your commit message accurate, which it currently
isn't.

Feel free to send a new patch with an updated commit message.  Also,
based on the contributor list [*], you should mark it with a TINYCHANGE
cookie.  It looks like you're hitting up against your TINYCHANGE code
limit, so please consider signing FSF copyright papers for future
patches.

[*] http://orgmode.org/worg/org-contribute.html

-- 
Kyle

  reply	other threads:[~2017-07-13 20:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-13  0:23 [PATCH] org-agenda tag completion works with ido Nathaniel Flath
2017-07-13  4:35 ` Kyle Meyer
2017-07-13 17:07   ` Nathaniel Flath
2017-07-13 18:02     ` Kyle Meyer
2017-07-13 18:14       ` Kyle Meyer
2017-07-13 18:19       ` Nathaniel Flath
2017-07-13 19:03         ` Nathaniel Flath
2017-07-13 19:19           ` Kyle Meyer
2017-07-13 19:52             ` Nathaniel Flath
2017-07-13 20:31               ` Kyle Meyer [this message]
2017-07-16 16:42                 ` Nathaniel Flath
2017-07-16 21:03                   ` Kyle Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wp7ccc4u.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=flat0103@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).