emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Puneeth Chaganti <punchagan@gmail.com>
To: emacs-orgmode <emacs-orgmode@gnu.org>
Subject: [PATCH] org-id-goto doesn't work if buffer is narrowed.
Date: Fri, 23 Oct 2015 20:41:07 +0530	[thread overview]
Message-ID: <CALnw1fRTyShwsk0_G0VMDzfC+6YCCiNxveua36y982LJFfeVNg@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 187 bytes --]

Hello,

I've attached a one-line patch to fix `org-id-goto' if the target
buffer is narrowed. Let me know if this fix sounds reasonable or if
you have other suggestions!

Thanks,
Puneeth

[-- Attachment #2: 0001-Widen-buffer-in-org-id-goto.patch --]
[-- Type: text/x-patch, Size: 756 bytes --]

From 3f3deb84fc2e2739307e820cdfa7de1c6fbf4f23 Mon Sep 17 00:00:00 2001
From: Puneeth Chaganti <punchagan@muse-amuse.in>
Date: Fri, 23 Oct 2015 20:21:59 +0530
Subject: [PATCH] Widen buffer in `org-id-goto'.

When the target buffer for `org-id-goto' is already open and narrowed,
it doesn't work.
---
 lisp/org-id.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/org-id.el b/lisp/org-id.el
index f86ef22..149a69b 100644
--- a/lisp/org-id.el
+++ b/lisp/org-id.el
@@ -296,6 +296,7 @@ Move the cursor to that entry in that buffer."
     (unless m
       (error "Cannot find entry with ID \"%s\"" id))
     (org-pop-to-buffer-same-window (marker-buffer m))
+    (widen)
     (goto-char m)
     (move-marker m nil)
     (org-show-context)))
-- 
2.1.4


             reply	other threads:[~2015-10-23 15:11 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-23 15:11 Puneeth Chaganti [this message]
2015-10-23 15:27 ` [PATCH] org-id-goto doesn't work if buffer is narrowed Rasmus
2015-10-23 18:05   ` Puneeth Chaganti
2015-10-23 18:48     ` John Kitchin
2015-10-23 20:22     ` Rasmus
2015-10-24  5:29       ` Puneeth Chaganti
2015-10-24 11:33         ` John Kitchin
2015-10-24 11:49           ` Puneeth Chaganti
2015-10-24 11:57           ` Nicolas Goaziou
2015-10-24 12:47           ` Rasmus
2015-10-24 17:48             ` John Kitchin
2015-10-24 18:03               ` Rasmus
2015-10-25 11:11                 ` John Kitchin
2015-10-24 12:27         ` Rasmus
2015-10-25  2:24           ` Puneeth Chaganti
2015-10-25  3:12             ` Puneeth Chaganti
2015-10-25  8:38               ` Nicolas Goaziou
2015-10-25  9:10                 ` Puneeth Chaganti
2015-10-25  9:42                   ` Nicolas Goaziou
2015-10-25  9:57                     ` Puneeth Chaganti
2015-10-25 11:19             ` Rasmus
2015-10-26 14:14               ` Puneeth Chaganti
2015-10-23 19:59   ` Matt Lundin
2015-10-23 20:18     ` Rasmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALnw1fRTyShwsk0_G0VMDzfC+6YCCiNxveua36y982LJFfeVNg@mail.gmail.com \
    --to=punchagan@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).