emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: John Kitchin <jkitchin@andrew.cmu.edu>
To: Rasmus <rasmus@gmx.us>
Cc: "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] org-id-goto doesn't work if buffer is narrowed.
Date: Sat, 24 Oct 2015 13:48:26 -0400	[thread overview]
Message-ID: <CAJ51ETqd+ciT8RxEH6iC8cJ5PtK0cfodk5bCPuXsPLAOKzRGZA@mail.gmail.com> (raw)
In-Reply-To: <87d1w4zb5b.fsf@gmx.us>

[-- Attachment #1: Type: text/plain, Size: 1993 bytes --]

I like the idea too. I worked out a partial solution for id links here:
http://kitchingroup.cheme.cmu.edu/blog/2015/10/24/Saving-the-current-restriction-and-restoring-it-while-following-links/
using the idea for saving and restoring the restriction.

John

-----------------------------------
Professor John Kitchin
Doherty Hall A207F
Department of Chemical Engineering
Carnegie Mellon University
Pittsburgh, PA 15213
412-268-7803
@johnkitchin
http://kitchingroup.cheme.cmu.edu


On Sat, Oct 24, 2015 at 8:47 AM, Rasmus <rasmus@gmx.us> wrote:

> John Kitchin <jkitchin@andrew.cmu.edu> writes:
>
> > Maybe I am missing something here. I would expect org-id-goto to actually
> > get to the id entry when it is used independent of narrowing. When used
> in
> > a program, I would expect this behavior to be wrapped in save-restriction
> > type macros, so it wouldn't change your restriction. But when used
> > interactively, e.g. when I click on a link, I expect the point to end up
> on
> > the id entry, with the buffer open in front of me, even if that means
> > widening. Is there some other expectation that makes sense? I feel like
> it
> > is up to me to decide if breaking the restriction is worth visiting the
> > link, and only by clicking on the link or running an interactive command
> > makes that happen.
>
> I prefer the behavior of C-c C-c on a footnote in a narrowed buffer.
> I.e. throw an error.
>
>
> > Is it possible to save a restriction in a variable? so that something
> like
> > C-c & could restore it?  the save-restriction macro must do something
> like
> > that, but the code seems to be hidden in the C-source for me.
>
>
> I thought about that.  I sort of like, but I also think it’s a potentially
> big change...
>
> A poor man’s solution might be:
>
>   (when (buffer-narrowed-p) (cons (point-min) (point-max)))
>
> Rasmus
>
> --
> When the facts change, I change my mind. What do you do, sir?
>
>
>

[-- Attachment #2: Type: text/html, Size: 2899 bytes --]

  reply	other threads:[~2015-10-24 17:48 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-23 15:11 [PATCH] org-id-goto doesn't work if buffer is narrowed Puneeth Chaganti
2015-10-23 15:27 ` Rasmus
2015-10-23 18:05   ` Puneeth Chaganti
2015-10-23 18:48     ` John Kitchin
2015-10-23 20:22     ` Rasmus
2015-10-24  5:29       ` Puneeth Chaganti
2015-10-24 11:33         ` John Kitchin
2015-10-24 11:49           ` Puneeth Chaganti
2015-10-24 11:57           ` Nicolas Goaziou
2015-10-24 12:47           ` Rasmus
2015-10-24 17:48             ` John Kitchin [this message]
2015-10-24 18:03               ` Rasmus
2015-10-25 11:11                 ` John Kitchin
2015-10-24 12:27         ` Rasmus
2015-10-25  2:24           ` Puneeth Chaganti
2015-10-25  3:12             ` Puneeth Chaganti
2015-10-25  8:38               ` Nicolas Goaziou
2015-10-25  9:10                 ` Puneeth Chaganti
2015-10-25  9:42                   ` Nicolas Goaziou
2015-10-25  9:57                     ` Puneeth Chaganti
2015-10-25 11:19             ` Rasmus
2015-10-26 14:14               ` Puneeth Chaganti
2015-10-23 19:59   ` Matt Lundin
2015-10-23 20:18     ` Rasmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJ51ETqd+ciT8RxEH6iC8cJ5PtK0cfodk5bCPuXsPLAOKzRGZA@mail.gmail.com \
    --to=jkitchin@andrew.cmu.edu \
    --cc=emacs-orgmode@gnu.org \
    --cc=rasmus@gmx.us \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).