From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Puneeth Chaganti <punchagan@gmail.com>
Cc: emacs-orgmode <emacs-orgmode@gnu.org>, Rasmus <rasmus@gmx.us>
Subject: Re: [PATCH] org-id-goto doesn't work if buffer is narrowed.
Date: Sun, 25 Oct 2015 09:38:52 +0100 [thread overview]
Message-ID: <87k2qbbaw3.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CALnw1fRd-NMBW7VTVFTzP6io4qApU3Am1g=LdReJf_zxi1UaDg@mail.gmail.com> (Puneeth Chaganti's message of "Sun, 25 Oct 2015 08:42:33 +0530")
Hello,
Puneeth Chaganti <punchagan@gmail.com> writes:
> Here is a patch that works for the case you describe.
Thank you. Some comments follow.
> + (org-id-show id 'org-pop-to-buffer-same-window))
(org-id-show id #'org-pop-to-buffer-same-window)
> +(defun org-id-show (id cmd)
> + "Show an entry with id ID by buffer-switching using CMD."
You should explain what is CMD. If it is a function, you should spell
out its signature.
> + (let ((m (org-id-find id 'marker)))
> + (unless m
> + (error "Cannot find entry with ID \"%s\"" id))
> + (if (not (equal (current-buffer) (marker-buffer m)))
> + (funcall cmd (marker-buffer m)))
(unless (eq (current-buffer) (marker-buffer m))
...)
> + (when (and (org-buffer-narrowed-p)
> + (let ((pos (marker-position m)))
> + (or (< pos (point-min))
> + (> pos (point-max)))))
> + (widen))
`org-buffer-narrowed-p' is not useful here since you check boundaries
right after its call.
(when (let ((pos (marker-position m)))
(or (< pos (point-min))
(> pos (point-max))))
(widen))
> + (goto-char m)
> + (move-marker m nil)
> + (org-show-context)))
I think this should be (org-show-context 'link-search) according to
`org-show-context-detail'.
> ;; id link type
>
> ;; Calling the following function is hard-coded into `org-store-link',
> @@ -659,25 +669,15 @@ optional argument MARKERP, return the position as a new marker."
> (defun org-id-open (id)
> "Go to the entry with id ID."
> (org-mark-ring-push)
> - (let ((m (org-id-find id 'marker))
> - cmd)
> - (unless m
> - (error "Cannot find entry with ID \"%s\"" id))
> - ;; Use a buffer-switching command in analogy to finding files
> - (setq cmd
> - (or
> - (cdr
> - (assq
> - (cdr (assq 'file org-link-frame-setup))
> - '((find-file . switch-to-buffer)
> - (find-file-other-window . switch-to-buffer-other-window)
> - (find-file-other-frame . switch-to-buffer-other-frame))))
> - 'switch-to-buffer-other-window))
> - (if (not (equal (current-buffer) (marker-buffer m)))
> - (funcall cmd (marker-buffer m)))
> - (goto-char m)
> - (move-marker m nil)
> - (org-show-context)))
> + (let ((cmd (or
> + (cdr
> + (assq
> + (cdr (assq 'file org-link-frame-setup))
> + '((find-file . switch-to-buffer)
> + (find-file-other-window . switch-to-buffer-other-window)
> + (find-file-other-frame . switch-to-buffer-other-frame))))
> + 'switch-to-buffer-other-window)))
#'switch-to-buffer-other-window
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2015-10-25 8:37 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-23 15:11 [PATCH] org-id-goto doesn't work if buffer is narrowed Puneeth Chaganti
2015-10-23 15:27 ` Rasmus
2015-10-23 18:05 ` Puneeth Chaganti
2015-10-23 18:48 ` John Kitchin
2015-10-23 20:22 ` Rasmus
2015-10-24 5:29 ` Puneeth Chaganti
2015-10-24 11:33 ` John Kitchin
2015-10-24 11:49 ` Puneeth Chaganti
2015-10-24 11:57 ` Nicolas Goaziou
2015-10-24 12:47 ` Rasmus
2015-10-24 17:48 ` John Kitchin
2015-10-24 18:03 ` Rasmus
2015-10-25 11:11 ` John Kitchin
2015-10-24 12:27 ` Rasmus
2015-10-25 2:24 ` Puneeth Chaganti
2015-10-25 3:12 ` Puneeth Chaganti
2015-10-25 8:38 ` Nicolas Goaziou [this message]
2015-10-25 9:10 ` Puneeth Chaganti
2015-10-25 9:42 ` Nicolas Goaziou
2015-10-25 9:57 ` Puneeth Chaganti
2015-10-25 11:19 ` Rasmus
2015-10-26 14:14 ` Puneeth Chaganti
2015-10-23 19:59 ` Matt Lundin
2015-10-23 20:18 ` Rasmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k2qbbaw3.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=punchagan@gmail.com \
--cc=rasmus@gmx.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).