From: Yuri Lensky <ydl@ydl.cm>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>,
Yuri Lensky <ydl@ydl.cm>
Subject: Re: [Patch] Support for dimming local to each agenda
Date: Fri, 14 Jul 2017 02:22:50 -0700 [thread overview]
Message-ID: <CAC38U-camWfm48pXnAyBcgUHEvhGNCW7TjEUr9CdSXs_mV_TOg@mail.gmail.com> (raw)
In-Reply-To: <87k23be81f.fsf@nicolasgoaziou.fr>
[-- Attachment #1: Type: text/plain, Size: 756 bytes --]
Why not save mark? This allows user-defined hooks in org-blocker-hooks more
freedom. That said, I am not sure of org-mode project conventions, so if
`save-excursion' is preferred I can change it to that.
Thanks.
On Fri, Jul 14, 2017 at 1:29 AM, Nicolas Goaziou <mail@nicolasgoaziou.fr>
wrote:
> Hello,
>
> Yuri Lensky <ydl@ydl.cm> writes:
>
> > Thanks. I have attached an updated patch that addresses your points (with
> > some additional cleanup).
>
> Thank you.
>
> >> Why is `save-mark-and-excursion' needed?
> >>
> > Because we are moving point to get to the heading, and in principle hooks
> > in org-blocker-hook can change point/mark.
>
> Since we don't care about mark, isn't `save-excursion' sufficient?
>
> Regards,
>
> --
> Nicolas Goaziou
>
[-- Attachment #2: Type: text/html, Size: 1347 bytes --]
next prev parent reply other threads:[~2017-07-14 9:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-12 0:39 [Patch] Support for dimming local to each agenda Yuri Lensky
2017-07-13 12:51 ` Nicolas Goaziou
2017-07-13 18:09 ` Yuri Lensky
2017-07-14 8:29 ` Nicolas Goaziou
2017-07-14 9:22 ` Yuri Lensky [this message]
2017-07-14 9:39 ` Nicolas Goaziou
2017-07-14 12:18 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAC38U-camWfm48pXnAyBcgUHEvhGNCW7TjEUr9CdSXs_mV_TOg@mail.gmail.com \
--to=ydl@ydl.cm \
--cc=emacs-orgmode@gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).