emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Yuri Lensky <ydl@ydl.cm>
Cc: "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Re: [Patch] Support for dimming local to each agenda
Date: Fri, 14 Jul 2017 14:18:01 +0200	[thread overview]
Message-ID: <87k23bciva.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87pod3cq6w.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Fri, 14 Jul 2017 11:39:51 +0200")

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Yuri Lensky <ydl@ydl.cm> writes:
>
>> Why not save mark? 
>
> We usually do not mess with it, unless this is explicit in the function
> documentation, e.g., `org-mark-ring-push'.
>
>> This allows user-defined hooks in org-blocker-hooks more freedom.
>
> I'm not sure this is a sufficient reason, really. Besides it's
> debatable.
>
>> That said, I am not sure of org-mode project conventions, so if
>> `save-excursion' is preferred I can change it to that.
>
> I'm going to do the change myself and apply you patch. No need for
> another iteration.

Done. Would you mind providing an ORG-NEWS entry?

Thank you!

      reply	other threads:[~2017-07-14 12:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-12  0:39 [Patch] Support for dimming local to each agenda Yuri Lensky
2017-07-13 12:51 ` Nicolas Goaziou
2017-07-13 18:09   ` Yuri Lensky
2017-07-14  8:29     ` Nicolas Goaziou
2017-07-14  9:22       ` Yuri Lensky
2017-07-14  9:39         ` Nicolas Goaziou
2017-07-14 12:18           ` Nicolas Goaziou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k23bciva.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=ydl@ydl.cm \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).