From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuri Lensky Subject: Re: [Patch] Support for dimming local to each agenda Date: Fri, 14 Jul 2017 02:22:50 -0700 Message-ID: References: <8760ewfqja.fsf@nicolasgoaziou.fr> <87k23be81f.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a11c17712dbfba4055443973b" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58297) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dVwoG-0001rH-Mv for emacs-orgmode@gnu.org; Fri, 14 Jul 2017 05:22:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dVwoF-0006au-Nj for emacs-orgmode@gnu.org; Fri, 14 Jul 2017 05:22:52 -0400 Received: from mail-oi0-x22f.google.com ([2607:f8b0:4003:c06::22f]:34097) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dVwoF-0006ag-Iq for emacs-orgmode@gnu.org; Fri, 14 Jul 2017 05:22:51 -0400 Received: by mail-oi0-x22f.google.com with SMTP id l130so66975257oib.1 for ; Fri, 14 Jul 2017 02:22:51 -0700 (PDT) In-Reply-To: <87k23be81f.fsf@nicolasgoaziou.fr> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Nicolas Goaziou Cc: "emacs-orgmode@gnu.org" , Yuri Lensky --001a11c17712dbfba4055443973b Content-Type: text/plain; charset="UTF-8" Why not save mark? This allows user-defined hooks in org-blocker-hooks more freedom. That said, I am not sure of org-mode project conventions, so if `save-excursion' is preferred I can change it to that. Thanks. On Fri, Jul 14, 2017 at 1:29 AM, Nicolas Goaziou wrote: > Hello, > > Yuri Lensky writes: > > > Thanks. I have attached an updated patch that addresses your points (with > > some additional cleanup). > > Thank you. > > >> Why is `save-mark-and-excursion' needed? > >> > > Because we are moving point to get to the heading, and in principle hooks > > in org-blocker-hook can change point/mark. > > Since we don't care about mark, isn't `save-excursion' sufficient? > > Regards, > > -- > Nicolas Goaziou > --001a11c17712dbfba4055443973b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Why not save mark? This allows user-defined hooks in org-b= locker-hooks more freedom. That said, I am not sure of org-mode project con= ventions, so if `save-excursion' is preferred I can change it to that.<= div>
Thanks.

On Fri, Jul 14, 2017 at 1:29 AM, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
Hello,

Yuri Lensky <ydl@ydl.cm> writes:
> Thanks. I have attached an updated patch that = addresses your points (with
> some additional cleanup).

Thank you.

>> Why is `save-mark-and-excursion' needed?
>>
> Because we are moving point to get to the heading, and in principle ho= oks
> in org-blocker-hook can change point/mark.

Since we don't care about mark, isn't `save-excursion' s= ufficient?

Regards,

--
Nicolas Goaziou

--001a11c17712dbfba4055443973b--