emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: emacs-orgmode@gnu.org
Subject: Emacs repo comment about org-element's use of avl-tree--*
Date: Thu, 18 Jan 2018 22:11:12 -0500	[thread overview]
Message-ID: <87zi5a35m7.fsf@kyleam.com> (raw)

Hello,

The commit below was made in Emacs's master branch (fe15532eef).  I'm
posting it here for review/discussion rather than backporting it.

-- >8 --
From: Stefan Monnier <monnier@iro.umontreal.ca>
Date: Thu, 11 Jan 2018 11:33:03 -0500
Subject: [PATCH] * lisp/org/org-element.el: Add comment about use of internal
 functions

---
 lisp/org/org-element.el | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lisp/org/org-element.el b/lisp/org/org-element.el
index 7a40d6933c..844349c2fc 100644
--- a/lisp/org/org-element.el
+++ b/lisp/org/org-element.el
@@ -4950,6 +4950,7 @@ org-element--cache-compare
 (defsubst org-element--cache-root ()
   "Return root value in cache.
 This function assumes `org-element--cache' is a valid AVL tree."
+  ;; FIXME: Why use internal functions of avl-tree?
   (avl-tree--node-left (avl-tree--dummyroot org-element--cache)))
 
 
@@ -4978,6 +4979,7 @@ org-element--cache-find
 		    (aref (car org-element--cache-sync-requests) 0)))
 	(node (org-element--cache-root))
 	lower upper)
+    ;; FIXME: Why use internal functions of avl-tree?
     (while node
       (let* ((element (avl-tree--node-data node))
 	     (begin (org-element-property :begin element)))
-- 
2.11.0

             reply	other threads:[~2018-01-19  3:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-19  3:11 Kyle Meyer [this message]
2018-01-19 16:59 ` Emacs repo comment about org-element's use of avl-tree--* Nicolas Goaziou
2018-01-20  5:44   ` Kyle Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zi5a35m7.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).