From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kyle Meyer Subject: Emacs repo comment about org-element's use of avl-tree--* Date: Thu, 18 Jan 2018 22:11:12 -0500 Message-ID: <87zi5a35m7.fsf@kyleam.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41305) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecN5L-00074P-Jg for emacs-orgmode@gnu.org; Thu, 18 Jan 2018 22:11:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ecN5H-0008NY-Jm for emacs-orgmode@gnu.org; Thu, 18 Jan 2018 22:11:19 -0500 Received: from pb-smtp2.pobox.com ([64.147.108.71]:58998) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ecN5H-0008NG-F6 for emacs-orgmode@gnu.org; Thu, 18 Jan 2018 22:11:15 -0500 Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 0C4ABD5F2C for ; Thu, 18 Jan 2018 22:11:14 -0500 (EST) Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 0440DD5F2B for ; Thu, 18 Jan 2018 22:11:14 -0500 (EST) Received: from localhost (unknown [24.60.167.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 80F2ED5F2A for ; Thu, 18 Jan 2018 22:11:13 -0500 (EST) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode@gnu.org Hello, The commit below was made in Emacs's master branch (fe15532eef). I'm posting it here for review/discussion rather than backporting it. -- >8 -- From: Stefan Monnier Date: Thu, 11 Jan 2018 11:33:03 -0500 Subject: [PATCH] * lisp/org/org-element.el: Add comment about use of internal functions --- lisp/org/org-element.el | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lisp/org/org-element.el b/lisp/org/org-element.el index 7a40d6933c..844349c2fc 100644 --- a/lisp/org/org-element.el +++ b/lisp/org/org-element.el @@ -4950,6 +4950,7 @@ org-element--cache-compare (defsubst org-element--cache-root () "Return root value in cache. This function assumes `org-element--cache' is a valid AVL tree." + ;; FIXME: Why use internal functions of avl-tree? (avl-tree--node-left (avl-tree--dummyroot org-element--cache))) @@ -4978,6 +4979,7 @@ org-element--cache-find (aref (car org-element--cache-sync-requests) 0))) (node (org-element--cache-root)) lower upper) + ;; FIXME: Why use internal functions of avl-tree? (while node (let* ((element (avl-tree--node-data node)) (begin (org-element-property :begin element))) -- 2.11.0