From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Kyle Meyer <kyle@kyleam.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Emacs repo comment about org-element's use of avl-tree--*
Date: Fri, 19 Jan 2018 17:59:43 +0100 [thread overview]
Message-ID: <87po65pyww.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87zi5a35m7.fsf@kyleam.com> (Kyle Meyer's message of "Thu, 18 Jan 2018 22:11:12 -0500")
Hello,
Kyle Meyer <kyle@kyleam.com> writes:
> The commit below was made in Emacs's master branch (fe15532eef). I'm
> posting it here for review/discussion rather than backporting it.
[...]
> + ;; FIXME: Why use internal functions of avl-tree?
> (avl-tree--node-left (avl-tree--dummyroot org-element--cache)))
[...]
> + ;; FIXME: Why use internal functions of avl-tree?
> (while node
> (let* ((element (avl-tree--node-data node))
> (begin (org-element-property :begin element)))
IIRC, this is because external functions do not give enough control over
the tree. For example, the code needs to be able to find a node whose
key matches a given predicate, efficiently.
This is not much of an issue, however. This implementation detail may
change at some point.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2018-01-19 16:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-19 3:11 Emacs repo comment about org-element's use of avl-tree--* Kyle Meyer
2018-01-19 16:59 ` Nicolas Goaziou [this message]
2018-01-20 5:44 ` Kyle Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87po65pyww.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=kyle@kyleam.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).