From: Kyle Meyer <kyle@kyleam.com>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: Zhitao Gong <zhitaao.gong@gmail.com>, emacs-orgmode@gnu.org
Subject: Re: About org-sort -> org-sort-list with custom sort function
Date: Tue, 09 May 2017 00:10:54 -0400 [thread overview]
Message-ID: <87y3u64qlt.fsf@kyleam.com> (raw)
In-Reply-To: <877f1r5q3b.fsf@kyleam.com>
Kyle Meyer <kyle@kyleam.com> writes:
> Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
>
>> The we may not need `call-interactively' at all.
>>
>> WDYT?
>
> Yeah, I agree that there's no need for call-interactively here because
> the interactive forms of org-table-sort-lines, org-sort-list,
> org-sort-entries are covered by org-sort's.
>
> Switched call-interactively to funcall in c1addc825.
Ehh, I should have looked more closely at org-table-sort-lines. Unlike
org-sort-entries and org-sort-list, it uses called-interactively-p to
determine whether it should prompt the user. I've put the
org-call-with-arg back, at least for now.
--
Kyle
prev parent reply other threads:[~2017-05-09 4:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-03 19:36 About org-sort -> org-sort-list with custom sort function Zhitao Gong
2017-05-07 2:55 ` Kyle Meyer
2017-05-07 10:00 ` Nicolas Goaziou
2017-05-07 14:20 ` Kyle Meyer
2017-05-07 15:37 ` Kyle Meyer
2017-05-08 9:48 ` Nicolas Goaziou
2017-05-08 15:24 ` Kyle Meyer
2017-05-08 16:23 ` Nicolas Goaziou
2017-05-08 16:45 ` Kyle Meyer
2017-05-08 16:48 ` Nicolas Goaziou
2017-05-09 19:47 ` [PATCH] org-sort: Read compare-func in interactive calls Kyle Meyer
2017-05-11 21:47 ` Nicolas Goaziou
2017-05-12 1:48 ` Kyle Meyer
2017-05-12 7:10 ` Nicolas Goaziou
2017-05-13 14:50 ` [PATCH v2] " Kyle Meyer
2017-05-14 8:24 ` Nicolas Goaziou
2017-05-14 13:45 ` Kyle Meyer
2017-05-14 16:51 ` Nicolas Goaziou
2017-05-14 20:54 ` Kyle Meyer
2017-05-17 12:32 ` Nicolas Goaziou
2017-05-09 4:10 ` Kyle Meyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3u64qlt.fsf@kyleam.com \
--to=kyle@kyleam.com \
--cc=emacs-orgmode@gnu.org \
--cc=mail@nicolasgoaziou.fr \
--cc=zhitaao.gong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).