emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: Zhitao Gong <zhitaao.gong@gmail.com>, emacs-orgmode@gnu.org
Subject: Re: About org-sort -> org-sort-list with custom sort function
Date: Sun, 07 May 2017 11:37:42 -0400	[thread overview]
Message-ID: <87pofk65kp.fsf@kyleam.com> (raw)
In-Reply-To: <87shkg695r.fsf@kyleam.com>

Kyle Meyer <kyle@kyleam.com> writes:

> Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
>
>> Kyle Meyer <kyle@kyleam.com> writes:
>>
>>> I'm a bit confused about why org-call-with-arg is necessary because I
>>> think call-interactively already propagates the current prefix argument,
>>> but perhaps I'm missing some subtlety here.  Either way ...
>>
>> I thought the same. I think we can replace `org-call-with-arg' with
>> `call-interactively' in master.
>
> OK, I'll have a closer look at which org-call-with-arg calls are
> unnecessary.

Grepping around, it looks like org-sort is the only place that uses
org-call-with-arg to send the argument through untouched.

Though, on second thought, using org-call-with-arg here rather than
call-interactively means that

  * the byte-compiler doesn't warn about WITH-CASE being unused. (I
    think marking it with an underscore would be confusing because it is
    "used".)

  * WITH-CASE isn't ignored when passed by a Lisp caller.

-- 
Kyle

  reply	other threads:[~2017-05-07 15:37 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-03 19:36 About org-sort -> org-sort-list with custom sort function Zhitao Gong
2017-05-07  2:55 ` Kyle Meyer
2017-05-07 10:00   ` Nicolas Goaziou
2017-05-07 14:20     ` Kyle Meyer
2017-05-07 15:37       ` Kyle Meyer [this message]
2017-05-08  9:48         ` Nicolas Goaziou
2017-05-08 15:24           ` Kyle Meyer
2017-05-08 16:23             ` Nicolas Goaziou
2017-05-08 16:45               ` Kyle Meyer
2017-05-08 16:48                 ` Nicolas Goaziou
2017-05-09 19:47                 ` [PATCH] org-sort: Read compare-func in interactive calls Kyle Meyer
2017-05-11 21:47                   ` Nicolas Goaziou
2017-05-12  1:48                     ` Kyle Meyer
2017-05-12  7:10                       ` Nicolas Goaziou
2017-05-13 14:50                         ` [PATCH v2] " Kyle Meyer
2017-05-14  8:24                           ` Nicolas Goaziou
2017-05-14 13:45                             ` Kyle Meyer
2017-05-14 16:51                               ` Nicolas Goaziou
2017-05-14 20:54                                 ` Kyle Meyer
2017-05-17 12:32                                   ` Nicolas Goaziou
2017-05-09  4:10             ` About org-sort -> org-sort-list with custom sort function Kyle Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pofk65kp.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    --cc=zhitaao.gong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).