From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kyle Meyer <kyle@kyleam.com>
Subject: Re: About org-sort -> org-sort-list with custom sort function
Date: Tue, 09 May 2017 00:10:54 -0400
Message-ID: <87y3u64qlt.fsf@kyleam.com>
References: <87inlhhgvf.fsf@gmail.com> <87vapd5qb0.fsf@kyleam.com>
	<87bmr57zqp.fsf@nicolasgoaziou.fr> <87shkg695r.fsf@kyleam.com>
	<87pofk65kp.fsf@kyleam.com> <871srz7k7h.fsf@nicolasgoaziou.fr>
	<877f1r5q3b.fsf@kyleam.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33376)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kyle@kyleam.com>) id 1d7wUI-0007fw-3I
	for emacs-orgmode@gnu.org; Tue, 09 May 2017 00:11:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kyle@kyleam.com>) id 1d7wUD-0003Ua-C8
	for emacs-orgmode@gnu.org; Tue, 09 May 2017 00:11:02 -0400
Received: from pb-smtp1.pobox.com ([64.147.108.70]:55982
	helo=sasl.smtp.pobox.com)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <kyle@kyleam.com>) id 1d7wUD-0003UH-48
	for emacs-orgmode@gnu.org; Tue, 09 May 2017 00:10:57 -0400
In-Reply-To: <877f1r5q3b.fsf@kyleam.com>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: Zhitao Gong <zhitaao.gong@gmail.com>, emacs-orgmode@gnu.org

Kyle Meyer <kyle@kyleam.com> writes:

> Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
>
>> The we may not need `call-interactively' at all. 
>>
>> WDYT?
>
> Yeah, I agree that there's no need for call-interactively here because
> the interactive forms of org-table-sort-lines, org-sort-list,
> org-sort-entries are covered by org-sort's.
>
> Switched call-interactively to funcall in c1addc825.

Ehh, I should have looked more closely at org-table-sort-lines.  Unlike
org-sort-entries and org-sort-list, it uses called-interactively-p to
determine whether it should prompt the user.  I've put the
org-call-with-arg back, at least for now.

-- 
Kyle