From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kyle Meyer <kyle@kyleam.com>
Subject: Re: [PATCH] org-agenda tag completion works with ido
Date: Thu, 13 Jul 2017 16:31:13 -0400
Message-ID: <87wp7ccc4u.fsf@kyleam.com>
References: <CAPrg3HBYSkjj7ev_YR0kciOWhSaF+Ui85tXH4GVtWo1-Frs1rQ@mail.gmail.com>
	<87bmopdkcy.fsf@kyleam.com>
	<CAPrg3HARqWPav4FVLfE2qfjsG8PQx6_dbFenZVanhxBbB5rV7g@mail.gmail.com>
	<878tjsdxl4.fsf@kyleam.com>
	<CAPrg3HB53sNem9PskfyysmONu_zTP1ZgW8FhcdEnF1oEJHr=Cg@mail.gmail.com>
	<CAPrg3HCVeFb1gyw2=KSSXLdten_Q7F-Bm5Wxmu550NemmGdRHg@mail.gmail.com>
	<87zic8cfg8.fsf@kyleam.com>
	<CAPrg3HA+STN07LFjOnYGgJRrZs1ik2HHNGbt5X8zX3tfvU4Ebw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58326)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kyle@kyleam.com>) id 1dVkld-0003bS-GI
	for emacs-orgmode@gnu.org; Thu, 13 Jul 2017 16:31:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kyle@kyleam.com>) id 1dVklY-0001zF-Sb
	for emacs-orgmode@gnu.org; Thu, 13 Jul 2017 16:31:21 -0400
Received: from pb-smtp1.pobox.com ([64.147.108.70]:58066
	helo=sasl.smtp.pobox.com)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <kyle@kyleam.com>) id 1dVklY-0001yw-Lr
	for emacs-orgmode@gnu.org; Thu, 13 Jul 2017 16:31:16 -0400
In-Reply-To: <CAPrg3HA+STN07LFjOnYGgJRrZs1ik2HHNGbt5X8zX3tfvU4Ebw@mail.gmail.com>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Nathaniel Flath <flat0103@gmail.com>
Cc: org-mode List <emacs-orgmode@gnu.org>

Nathaniel Flath <flat0103@gmail.com> writes:

> I suppose so.  I still think this is a correct patch, since it doesn't
> make sense to filter for non-existent tags.

I agreed that require-match should be t earlier in the thread, but it
turns out that that's not the source of your issue.  I took time to
clarify this in order to a) help you solve your ido completion issue
everywhere, not just one specific case in one particular package, and b)
make the description in your commit message accurate, which it currently
isn't.

Feel free to send a new patch with an updated commit message.  Also,
based on the contributor list [*], you should mark it with a TINYCHANGE
cookie.  It looks like you're hitting up against your TINYCHANGE code
limit, so please consider signing FSF copyright papers for future
patches.

[*] http://orgmode.org/worg/org-contribute.html

-- 
Kyle