Bug: links are not highlighted anymore with Org Mode 9.2

Bug: links are not highlighted anymore with Org Mode 9.2

[Daniel Borchmann]

[-- Attachment #1: Type: text/plain, Size: 919 bytes --]


Hey,

links in Org Mode 9.2 are not highlighted anymore if no :face keyword is
given in ‘org-link-parameters’.  The reason for this seems to be that
‘org-activate-links’ uses the following code to determine which face to
use:

--8<---------------cut here---------------start------------->8---
(pcase (org-link-get-parameter type :face)
  ((and (pred functionp) face) (funcall face path))
  ((and (pred facep) face) face)
  ((and (pred consp) face) face) ;anonymous
  (_ 'org-link))
--8<---------------cut here---------------end--------------->8---

However, ‘nil’ is a valid face, and thus this form returns ‘nil’ instead
of the default ‘org-link’ face if no :face keyword is given.

Best,

  Daniel

PS: Thanks a ton for Org Mode, I literally couldn’t live without it! :)

-- 
Daniel Borchmann
GPG (Mail)            0849 473E 6BF0 B504 DF0B  D640 455E 3610 01FF 778F

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

Re: Bug: links are not highlighted anymore with Org Mode 9.2

[Nicolas Goaziou]

Hello,

Daniel Borchmann <daniel@algebra20.de> writes:

> links in Org Mode 9.2 are not highlighted anymore if no :face keyword is
> given in ‘org-link-parameters’.

I cannot reproduce this.

> The reason for this seems to be that
> ‘org-activate-links’ uses the following code to determine which face to
> use:
>
> --8<---------------cut here---------------start------------->8---
> (pcase (org-link-get-parameter type :face)
>   ((and (pred functionp) face) (funcall face path))
>   ((and (pred facep) face) face)
>   ((and (pred consp) face) face) ;anonymous
>   (_ 'org-link))
> --8<---------------cut here---------------end--------------->8---
>
> However, ‘nil’ is a valid face,

No, it isn't: (facep nil) => nil

> and thus this form returns ‘nil’ instead of the default ‘org-link’
> face if no :face keyword is given.

I don't think the analysis is correct, per above.

Regards,

-- 
Nicolas Goaziou

Re: Bug: links are not highlighted anymore with Org Mode 9.2

[Daniel Borchmann]

[-- Attachment #1: Type: text/plain, Size: 1203 bytes --]

ghItlhpu' Nicolas Goaziou <mail@nicolasgoaziou.fr>:
>> The reason for this seems to be that
>> ‘org-activate-links’ uses the following code to determine which face to
>> use:
>>
>> --8<---------------cut here---------------start------------->8---
>> (pcase (org-link-get-parameter type :face)
>>   ((and (pred functionp) face) (funcall face path))
>>   ((and (pred facep) face) face)
>>   ((and (pred consp) face) face) ;anonymous
>>   (_ 'org-link))
>> --8<---------------cut here---------------end--------------->8---
>>
>> However, ‘nil’ is a valid face,
>
> No, it isn't: (facep nil) => nil

Interesting!

I get (in the *scratch* buffer):

    (facep nil) → [face unspecified unspecified unspecified unspecified unspecified unspecified unspecified unspecified unspecified unspecified unspecified ...]

M-x emacs-version returns

    GNU Emacs 26.1 (build 1, x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars) of 2018-12-26, modified by Debian

So this is more likely an issue of Emacs itself?  Maybe it has been
fixed in a later version?

Thanks!

  Daniel

-- 
Daniel Borchmann
GPG (Mail)            0849 473E 6BF0 B504 DF0B  D640 455E 3610 01FF 778F

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

Re: Bug: links are not highlighted anymore with Org Mode 9.2

[Daniel Borchmann]

[-- Attachment #1: Type: text/plain, Size: 658 bytes --]

ghItlhpu' Daniel Borchmann <daniel@algebra20.de>:
> I get (in the *scratch* buffer):
>
>     (facep nil) → [face unspecified unspecified unspecified unspecified unspecified unspecified unspecified unspecified unspecified unspecified unspecified ...]

Seems this an issue with my configuration, not Emacs itself, as stock
Emacs (started with emacs -Q) returns nil for (facep nil), as you
mentioned.  Indeed, somehow something defined ‘nil’ as a face for me,
causing the above issues.

So no bug in Org Mode, sorry for the noise :)

  Daniel

-- 
Daniel Borchmann
GPG (Mail)            0849 473E 6BF0 B504 DF0B  D640 455E 3610 01FF 778F

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]