Re: Bug: links are not highlighted anymore with Org Mode 9.2

[Nicolas Goaziou <mail@nicolasgoaziou.fr>]

Hello,

Daniel Borchmann <daniel@algebra20.de> writes:

> links in Org Mode 9.2 are not highlighted anymore if no :face keyword is
> given in ‘org-link-parameters’.

I cannot reproduce this.

> The reason for this seems to be that
> ‘org-activate-links’ uses the following code to determine which face to
> use:
>
> --8<---------------cut here---------------start------------->8---
> (pcase (org-link-get-parameter type :face)
>   ((and (pred functionp) face) (funcall face path))
>   ((and (pred facep) face) face)
>   ((and (pred consp) face) face) ;anonymous
>   (_ 'org-link))
> --8<---------------cut here---------------end--------------->8---
>
> However, ‘nil’ is a valid face,

No, it isn't: (facep nil) => nil

> and thus this form returns ‘nil’ instead of the default ‘org-link’
> face if no :face keyword is given.

I don't think the analysis is correct, per above.

Regards,

-- 
Nicolas Goaziou