* %K template escape doesn't link to exact task headline
@ 2017-07-13 10:54 Michal Politowski
2017-07-13 12:27 ` Nicolas Goaziou
0 siblings, 1 reply; 4+ messages in thread
From: Michal Politowski @ 2017-07-13 10:54 UTC (permalink / raw)
To: emacs-orgmode
Hello everyone and thank you for the fascinating org mode,
Is the behaviour of %K a bug in the documentation, in the implementation,
or just my unfounded expectation?
It is supposed to link "to the currently clocked task" but it is implemented
in org-capture.el as
(v-K (if (marker-buffer org-clock-marker)
(org-make-link-string
(buffer-file-name (marker-buffer org-clock-marker))
org-clock-heading)))
<http://orgmode.org/cgit.cgi/org-mode.git/tree/lisp/org-capture.el#n1611>
which only puts the headline text in the link description,
the actual link is just to the task file - not what I would expect.
--
Michał Politowski
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: %K template escape doesn't link to exact task headline
2017-07-13 10:54 %K template escape doesn't link to exact task headline Michal Politowski
@ 2017-07-13 12:27 ` Nicolas Goaziou
2017-07-13 13:30 ` Michal Politowski
0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Goaziou @ 2017-07-13 12:27 UTC (permalink / raw)
To: Michal Politowski; +Cc: emacs-orgmode
Hello,
Michal Politowski <mpol@meep.pl> writes:
> Hello everyone and thank you for the fascinating org mode,
>
> Is the behaviour of %K a bug in the documentation, in the implementation,
> or just my unfounded expectation?
>
> It is supposed to link "to the currently clocked task" but it is implemented
> in org-capture.el as
>
> (v-K (if (marker-buffer org-clock-marker)
> (org-make-link-string
> (buffer-file-name (marker-buffer org-clock-marker))
> org-clock-heading)))
>
> <http://orgmode.org/cgit.cgi/org-mode.git/tree/lisp/org-capture.el#n1611>
>
> which only puts the headline text in the link description,
> the actual link is just to the task file - not what I would expect.
Fixed. Thank you.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: %K template escape doesn't link to exact task headline
2017-07-13 12:27 ` Nicolas Goaziou
@ 2017-07-13 13:30 ` Michal Politowski
2017-07-14 8:41 ` Nicolas Goaziou
0 siblings, 1 reply; 4+ messages in thread
From: Michal Politowski @ 2017-07-13 13:30 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: emacs-orgmode
On Thu, 13 Jul 2017 14:27:11 +0200, Nicolas Goaziou wrote:
> Hello,
>
> Michal Politowski <mpol@meep.pl> writes:
>
> > Hello everyone and thank you for the fascinating org mode,
> >
> > Is the behaviour of %K a bug in the documentation, in the implementation,
> > or just my unfounded expectation?
> >
> > It is supposed to link "to the currently clocked task" but it is implemented
> > in org-capture.el as
> >
> > (v-K (if (marker-buffer org-clock-marker)
> > (org-make-link-string
> > (buffer-file-name (marker-buffer org-clock-marker))
> > org-clock-heading)))
> >
> > <http://orgmode.org/cgit.cgi/org-mode.git/tree/lisp/org-capture.el#n1611>
> >
> > which only puts the headline text in the link description,
> > the actual link is just to the task file - not what I would expect.
>
> Fixed. Thank you.
Thank you. Wouldn't it be better to still have a link description though?
Probably both versions have advantages.
diff --git a/lisp/org-capture.el b/lisp/org-capture.el
index 44dbb7f96..7b880cf9a 100644
--- a/lisp/org-capture.el
+++ b/lisp/org-capture.el
@@ -1613,7 +1613,8 @@ The template may still contain \"%?\" for cursor positioning."
(org-make-link-string
(format "%s::%s"
(buffer-file-name (marker-buffer org-clock-marker))
- (org-no-properties org-clock-heading)))
+ (org-no-properties org-clock-heading))
+ (org-no-properties org-clock-heading))
""))
(v-f (or (org-capture-get :original-file-nondirectory) ""))
(v-F (or (org-capture-get :original-file) ""))
--
Michał Politowski
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: %K template escape doesn't link to exact task headline
2017-07-13 13:30 ` Michal Politowski
@ 2017-07-14 8:41 ` Nicolas Goaziou
0 siblings, 0 replies; 4+ messages in thread
From: Nicolas Goaziou @ 2017-07-14 8:41 UTC (permalink / raw)
To: Michal Politowski; +Cc: emacs-orgmode
Hello,
Michal Politowski <mpol@meep.pl> writes:
> Thank you. Wouldn't it be better to still have a link description
> though?
Done. Thank you.
Regards,
--
Nicolas Goaziou 0x80A93738
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-07-14 8:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-13 10:54 %K template escape doesn't link to exact task headline Michal Politowski
2017-07-13 12:27 ` Nicolas Goaziou
2017-07-13 13:30 ` Michal Politowski
2017-07-14 8:41 ` Nicolas Goaziou
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).