emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Michal Politowski <mpol@meep.pl>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: emacs-orgmode@gnu.org
Subject: Re: %K template escape doesn't link to exact task headline
Date: Thu, 13 Jul 2017 15:30:06 +0200	[thread overview]
Message-ID: <20170713133006.n3tno7gxbihb7el7@meep.pl> (raw)
In-Reply-To: <87mv88frog.fsf@nicolasgoaziou.fr>

On Thu, 13 Jul 2017 14:27:11 +0200, Nicolas Goaziou wrote:
> Hello,
> 
> Michal Politowski <mpol@meep.pl> writes:
> 
> > Hello everyone and thank you for the fascinating org mode,
> >
> > Is the behaviour of %K a bug in the documentation, in the implementation,
> > or just my unfounded expectation?
> >
> > It is supposed to link "to the currently clocked task" but it is implemented
> > in org-capture.el as
> >
> > (v-K (if (marker-buffer org-clock-marker)
> > 		  (org-make-link-string
> > 		   (buffer-file-name (marker-buffer org-clock-marker))
> > 		   org-clock-heading)))
> >
> > <http://orgmode.org/cgit.cgi/org-mode.git/tree/lisp/org-capture.el#n1611>
> >
> > which only puts the headline text in the link description,
> > the actual link is just to the task file - not what I would expect.
> 
> Fixed. Thank you.

Thank you. Wouldn't it be better to still have a link description though?
Probably both versions have advantages.

diff --git a/lisp/org-capture.el b/lisp/org-capture.el
index 44dbb7f96..7b880cf9a 100644
--- a/lisp/org-capture.el
+++ b/lisp/org-capture.el
@@ -1613,7 +1613,8 @@ The template may still contain \"%?\" for cursor positioning."
                  (org-make-link-string
                   (format "%s::%s"
                           (buffer-file-name (marker-buffer org-clock-marker))
-                          (org-no-properties org-clock-heading)))
+                          (org-no-properties org-clock-heading))
+                  (org-no-properties org-clock-heading))
                ""))
         (v-f (or (org-capture-get :original-file-nondirectory) ""))
         (v-F (or (org-capture-get :original-file) ""))


-- 
Michał Politowski

  reply	other threads:[~2017-07-13 13:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-13 10:54 %K template escape doesn't link to exact task headline Michal Politowski
2017-07-13 12:27 ` Nicolas Goaziou
2017-07-13 13:30   ` Michal Politowski [this message]
2017-07-14  8:41     ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170713133006.n3tno7gxbihb7el7@meep.pl \
    --to=mpol@meep.pl \
    --cc=emacs-orgmode@gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).