From: Georgiy Tugai <georgiy.tugai@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-clock: Fix clock report sometimes ignoring hours before :wstart
Date: Sat, 7 Oct 2017 13:14:48 +1030 [thread overview]
Message-ID: <20171007024448.GH5513@gmail.com> (raw)
In-Reply-To: <87k209k68n.fsf@nicolasgoaziou.fr>
[-- Attachment #1: Type: text/plain, Size: 954 bytes --]
While implementing the test, I found a bug in my patch. Thanks for
pointing out the test suite! :)
Should I flatten the commits i.e. send original + new changes as one
patch?
Also, I have not yet signed FSF papers -- will this pose a problem for
incorporating the test suite changes?
Regards,
Georgiy
On 05 Oct, Nicolas Goaziou wrote:
> Hello,
>
> Georgiy Tugai <georgiy.tugai@gmail.com> writes:
>
> > * lisp/org-clock (org-clocktable-steps): Fix weekly-step clock report
> > ignoring hours between start of period and start of week, when start
> > of period is on a day of week numerically less than start of week.
> >
> > Clock report now always inserts a "week" starting at the start of
> > the period, if necessary; all following weeks start on the start of
> > the week as expected.
>
> Thank you.
>
> Would you mind adding a test in test-org-clock.el?
>
> Regards,
>
> --
> Nicolas Goaziou
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2017-10-07 2:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-04 11:26 [PATCH] org-clock: Fix clock report sometimes ignoring hours before :wstart Georgiy Tugai
2017-10-05 14:40 ` Nicolas Goaziou
2017-10-07 2:44 ` Georgiy Tugai [this message]
2017-10-07 6:44 ` Nicolas Goaziou
2017-10-07 11:31 ` [PATCH v2] " Georgiy Tugai
2017-10-08 8:55 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171007024448.GH5513@gmail.com \
--to=georgiy.tugai@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).