From mboxrd@z Thu Jan 1 00:00:00 1970 From: Georgiy Tugai Subject: Re: [PATCH] org-clock: Fix clock report sometimes ignoring hours before :wstart Date: Sat, 7 Oct 2017 13:14:48 +1030 Message-ID: <20171007024448.GH5513@gmail.com> References: <20171004112628.GE5513@gmail.com> <87k209k68n.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="liqSWPDvh3eyfZ9k" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53898) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e0f6s-0000hr-E8 for emacs-orgmode@gnu.org; Fri, 06 Oct 2017 22:45:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e0f6l-0007h5-TE for emacs-orgmode@gnu.org; Fri, 06 Oct 2017 22:45:00 -0400 Received: from mail-pf0-x22a.google.com ([2607:f8b0:400e:c00::22a]:54272) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e0f6l-0007gE-Lw for emacs-orgmode@gnu.org; Fri, 06 Oct 2017 22:44:55 -0400 Received: by mail-pf0-x22a.google.com with SMTP id m28so5434621pfi.11 for ; Fri, 06 Oct 2017 19:44:55 -0700 (PDT) Received: from gmail.com ([101.187.171.220]) by smtp.googlemail.com with ESMTPSA id m185sm4878471pfm.181.2017.10.06.19.44.52 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 06 Oct 2017 19:44:53 -0700 (PDT) Content-Disposition: inline In-Reply-To: <87k209k68n.fsf@nicolasgoaziou.fr> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode@gnu.org --liqSWPDvh3eyfZ9k Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable While implementing the test, I found a bug in my patch. Thanks for pointing out the test suite! :) Should I flatten the commits i.e. send original + new changes as one patch? Also, I have not yet signed FSF papers -- will this pose a problem for incorporating the test suite changes? Regards, Georgiy On 05 Oct, Nicolas Goaziou wrote: > Hello, >=20 > Georgiy Tugai writes: >=20 > > * lisp/org-clock (org-clocktable-steps): Fix weekly-step clock report > > ignoring hours between start of period and start of week, when start > > of period is on a day of week numerically less than start of week. > > > > Clock report now always inserts a "week" starting at the start of > > the period, if necessary; all following weeks start on the start of > > the week as expected. >=20 > Thank you. >=20 > Would you mind adding a test in test-org-clock.el? >=20 > Regards, >=20 > --=20 > Nicolas Goaziou >=20 --liqSWPDvh3eyfZ9k Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEt94/pILzkhb5UE6EVMIg1W9Zs5kFAlnYP6AACgkQVMIg1W9Z s5l2yQgApRBpQziDoXToeDyEdfylj+XYfjUKfCEVsxkL9GPxkwez24Ar8xgpOizs ujetbf1zZETUEiz+VBZkfs2rNN+4dDDhaIdV4kvnskFo1VLaYxg1KyEDj2eLa92W 8vJpr7p7EHXpc++z5Zd+bJw7arWYp5e6AU05ByWY/AMLKMZrD7HiMDVscBycLcg4 6ZQa42mNdXB5Dt5d8Ld1SVNIvCpSdToL1PM6b4IHOI3CcC7omE7SbzPe7JnvopKS PwSgNzt7Qd3DrbhszOKTnO7cvLzVM2hOUNNBdHHgGxHTuAFXPzxafeJuPP8BaxtQ V00Cdt5qsJcYhGY00BLuvW4ol/RiaA== =Nm/8 -----END PGP SIGNATURE----- --liqSWPDvh3eyfZ9k--