From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH 6/6] lib: choose oldest message when breaking reference loops
Date: Wed, 25 Apr 2018 14:48:42 +0300 [thread overview]
Message-ID: <m2wowvld5x.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <87fu3kkq7c.fsf@tethera.net>
On Tue, Apr 24 2018, David Bremner wrote:
> Tomi Ollila <tomi.ollila@iki.fi> writes:
>
>> Otherwise the series _looks_ good do me. The thing that disturbs me are
>> these `strlen (in_reply_to)` contents. Perhaps SomeOne(TM) changes these
>> to e.g. in_reply_to[0] in the future...
>>
>
> That same file defines and uses an EMPTY_STRING macro. We should
> probably be consistent, either use that macro everywehre or
> nowhere. Perhaps move it to lib/notmuch-private.h?
I looked macro replacement for in_reply_to[0] through internet, but
weren't smart enough to git grep notmuch source tree.
I'd say use it everwhere now that it is there (and move it...)
SMOP (or not so) for someone(tm)
>
> d
Tomi
next prev parent reply other threads:[~2018-04-25 11:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-14 1:46 reference loop fix and tests, v2 David Bremner
2018-04-14 1:46 ` [PATCH 1/5] test: two new messages for the 'broken' corpus David Bremner
2018-04-14 22:24 ` Tomi Ollila
2018-04-15 7:36 ` Daniel Kahn Gillmor
2018-04-14 1:46 ` [PATCH 2/5] test: add known broken test for indexing an In-Reply-To loop David Bremner
2018-04-14 1:46 ` [PATCH 3/5] lib: break reference loop by choosing arbitrary top level msg David Bremner
2018-04-15 7:38 ` Daniel Kahn Gillmor
2018-04-14 1:46 ` [PATCH 4/5] test: add second reference loop test David Bremner
2018-04-14 1:46 ` [PATCH 5/5] NEWS: add item for reference loop fix David Bremner
2018-04-20 18:31 ` v3 " David Bremner
2018-04-20 18:31 ` [PATCH 1/6] test: two new messages for the 'broken' corpus David Bremner
2018-04-20 18:31 ` [PATCH 2/6] test: add known broken test for indexing an In-Reply-To loop David Bremner
2018-04-20 18:31 ` [PATCH 3/6] lib: break reference loop by choosing arbitrary top level msg David Bremner
2018-04-20 18:31 ` [PATCH 4/6] NEWS: add item for reference loop fix David Bremner
2018-04-20 18:31 ` [PATCH 5/6] test: add known broken test for thread ordering from a loop David Bremner
2018-04-20 18:31 ` [PATCH 6/6] lib: choose oldest message when breaking reference loops David Bremner
2018-04-21 17:53 ` Tomi Ollila
2018-04-25 1:52 ` David Bremner
2018-04-25 11:48 ` Tomi Ollila [this message]
2018-04-25 20:41 ` reference loop fix and tests, v2 David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2wowvld5x.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).