From: David Bremner <david@tethera.net>
To: notmuch@notmuchmail.org
Subject: [PATCH 4/5] test: add second reference loop test
Date: Fri, 13 Apr 2018 22:46:09 -0300 [thread overview]
Message-ID: <20180414014610.15438-5-david@tethera.net> (raw)
In-Reply-To: <20180414014610.15438-1-david@tethera.net>
Guard against regressions where there is no crash, but output is
wrong.
---
test/T050-new.sh | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/test/T050-new.sh b/test/T050-new.sh
index 222c341e..91722e24 100755
--- a/test/T050-new.sh
+++ b/test/T050-new.sh
@@ -355,7 +355,16 @@ EOF
test_expect_equal_file EXPECTED OUTPUT
add_email_corpus broken
-test_begin_subtest "reference loop"
+test_begin_subtest "reference loop does not crash"
test_expect_code 0 "notmuch show --format=json id:9379QM5Z39_5aa86b134fcfb_174033fc97a2cb98c7198d_sprut@zendesk.com > OUTPUT"
+test_begin_subtest "reference loop outputs both messages"
+threadid=$(notmuch search --output=threads id:9379QM5Z39_5aa86b134fcfb_174033fc97a2cb98c7198d_sprut@zendesk.com)
+notmuch show --format=mbox $threadid | grep '^Message-ID' | sort > OUTPUT
+cat <<EOF
+Message-ID: <9379QM5Z39_5aa86b134fcfb_174033fc97a2cb98c7198d_sprut@zendesk.com>
+Message-ID: <9379QM5Z39_5aa86b1350504_174eb3fc97a2cb98c71674_sprut@zendesk.com>
+EOF
+test_expect_equal_file /dev/null OUTPUT
+
test_done
--
2.17.0
next prev parent reply other threads:[~2018-04-14 1:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-14 1:46 reference loop fix and tests, v2 David Bremner
2018-04-14 1:46 ` [PATCH 1/5] test: two new messages for the 'broken' corpus David Bremner
2018-04-14 22:24 ` Tomi Ollila
2018-04-15 7:36 ` Daniel Kahn Gillmor
2018-04-14 1:46 ` [PATCH 2/5] test: add known broken test for indexing an In-Reply-To loop David Bremner
2018-04-14 1:46 ` [PATCH 3/5] lib: break reference loop by choosing arbitrary top level msg David Bremner
2018-04-15 7:38 ` Daniel Kahn Gillmor
2018-04-14 1:46 ` David Bremner [this message]
2018-04-14 1:46 ` [PATCH 5/5] NEWS: add item for reference loop fix David Bremner
2018-04-20 18:31 ` v3 " David Bremner
2018-04-20 18:31 ` [PATCH 1/6] test: two new messages for the 'broken' corpus David Bremner
2018-04-20 18:31 ` [PATCH 2/6] test: add known broken test for indexing an In-Reply-To loop David Bremner
2018-04-20 18:31 ` [PATCH 3/6] lib: break reference loop by choosing arbitrary top level msg David Bremner
2018-04-20 18:31 ` [PATCH 4/6] NEWS: add item for reference loop fix David Bremner
2018-04-20 18:31 ` [PATCH 5/6] test: add known broken test for thread ordering from a loop David Bremner
2018-04-20 18:31 ` [PATCH 6/6] lib: choose oldest message when breaking reference loops David Bremner
2018-04-21 17:53 ` Tomi Ollila
2018-04-25 1:52 ` David Bremner
2018-04-25 11:48 ` Tomi Ollila
2018-04-25 20:41 ` reference loop fix and tests, v2 David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180414014610.15438-5-david@tethera.net \
--to=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).