From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tomi.ollila@iki.fi>
Received: from localhost (localhost [127.0.0.1])
 by arlo.cworth.org (Postfix) with ESMTP id E2F4A6DE0289
 for <notmuch@notmuchmail.org>; Wed, 25 Apr 2018 04:48:50 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at cworth.org
X-Spam-Flag: NO
X-Spam-Score: 0.475
X-Spam-Level: 
X-Spam-Status: No, score=0.475 tagged_above=-999 required=5 tests=[AWL=-0.177, 
 SPF_NEUTRAL=0.652] autolearn=disabled
Received: from arlo.cworth.org ([127.0.0.1])
 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id PQOPJTaW0WKo for <notmuch@notmuchmail.org>;
 Wed, 25 Apr 2018 04:48:50 -0700 (PDT)
Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
 by arlo.cworth.org (Postfix) with ESMTP id 2E7D36DE0286
 for <notmuch@notmuchmail.org>; Wed, 25 Apr 2018 04:48:50 -0700 (PDT)
Received: from guru.guru-group.fi (localhost [IPv6:::1])
 by guru.guru-group.fi (Postfix) with ESMTP id 8B76110006A;
 Wed, 25 Apr 2018 14:48:42 +0300 (EEST)
From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH 6/6] lib: choose oldest message when breaking reference
 loops
In-Reply-To: <87fu3kkq7c.fsf@tethera.net>
References: <20180414014610.15438-6-david@tethera.net>
 <20180420183135.14331-1-david@tethera.net>
 <20180420183135.14331-7-david@tethera.net>
 <m2bmeccuo9.fsf@guru.guru-group.fi> <87fu3kkq7c.fsf@tethera.net>
User-Agent: Notmuch/0.26.1+22~g888240d (https://notmuchmail.org) Emacs/25.2.1
 (x86_64-unknown-linux-gnu)
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
 !)g;OY^,BjTbr)Np:%c_o'jj,Z
Date: Wed, 25 Apr 2018 14:48:42 +0300
Message-ID: <m2wowvld5x.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: "Use and development of the notmuch mail system."
 <notmuch.notmuchmail.org>
List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Apr 2018 11:48:51 -0000

On Tue, Apr 24 2018, David Bremner wrote:

> Tomi Ollila <tomi.ollila@iki.fi> writes:
>
>> Otherwise the series _looks_ good do me. The thing that disturbs me are
>> these `strlen (in_reply_to)` contents. Perhaps SomeOne(TM) changes these
>> to e.g. in_reply_to[0] in the future...
>>
>
> That same file defines and uses an EMPTY_STRING macro. We should
> probably be consistent, either use that macro everywehre or
> nowhere. Perhaps move it to lib/notmuch-private.h?

I looked macro replacement for in_reply_to[0] through internet, but 
weren't smart enough to git grep notmuch source tree. 

I'd say use it everwhere now that it is there (and move it...)

SMOP (or not so) for someone(tm)

>
> d

Tomi