Re: [PATCH] gzclose_r() and gzclose_w() are not available in older...

[Tomi Ollila <tomi.ollila@iki.fi>]

On Mon, Nov 21 2016, David Bremner <david@tethera.net> wrote:

> I take the submitters word for the first version supporting gzclose

I tried this patch on Scientific Linux 6.2 -- after applied it I changed
the check to >= 1.2.3 (to the one used in sl62).

This compiles fine but tests fails miserably.

According to http://packages.ubuntu.com/hu/source/precise/zlib
it uses zlib 1.2.3.4...

... I created container based on ubuntu:12.04

... and ... the tests fail there as bad as with 1.2.3.


SO, it looks to me that (unfortunately) just doing this is not enough
(knowing that one needs to test dump/restore for this patch to be feasible
may not be obvious to everyone ;/).

My supportive patch: id:1397809386-23356-1-git-send-email-tomi.ollila@iki.fi
-- http://article.gmane.org/gmane.mail.notmuch.general/17916
still applies to many systems with older zlib versions; probably to precise
as well.


test output examples:

Warning: cannot parse query: EqÀ2ýA1?çr"9h nV)VC[æ'c¤LÔs£eM NJV>.<C0e
(skipping)
Error reading (gzipped) input: out of memory
^[[?1;2c^[[?1;2c^[[?1;2c^[[?1;2c^[[?1;2c^[[?1;2c^[[?1;2c^[[?1;2c^[[?1;2c^[[?1;2c^[[?1;2c^[[?1;2c^[[?1;2c^[[?1;2c^[[?1;2c^[[?1;2c^[[?1;2c^[[?1;2c^[[?1;2c^[[?1;2c^[[?1;2c^[[?1;2c^[[?1;2c


./T600-named-queries.sh: line 49: 10825 Segmentation fault      (core
dumped) notmuch restore < BEFORE