From: David Bremner <david@tethera.net>
To: Ico Doornekamp <ico@pruts.nl>, notmuch@notmuchmail.org
Cc: Ico Doornekamp <ico@pruts.nl>
Subject: Re: [PATCH] gzclose_r() and gzclose_w() are not available in older versions of zlib such as the version on Ubuntu LTS 12.04. Changing to gzclose() allows notmuch to work on older versions as well
Date: Mon, 21 Nov 2016 14:28:09 -0400 [thread overview]
Message-ID: <878tscofgm.fsf@tesseract.cs.unb.ca> (raw)
In-Reply-To: <1479640516-33847-1-git-send-email-ico@pruts.nl>
Ico Doornekamp <ico@pruts.nl> writes:
> ---
> configure | 4 ++--
> notmuch-dump.c | 4 ++--
> notmuch-restore.c | 2 +-
> 3 files changed, 5 insertions(+), 5 deletions(-)
Looking at the docs, this looks sensible.
,----
| Same as gzclose(), but gzclose_r() is only for use when reading, and
| gzclose_w() is only for use when writing or appending. The advantage to
| using these instead of gzclose() is that they avoid linking in zlib
| compression or decompression code that is not used when only reading or
| only writing respectively. If gzclose() is used, then both compression
| and decompression code will be included the application when linking to
| a static zlib library.
`----
Probably the commit message could include a paraphrase/quote of the
above.
I take the submitters word for the first version supporting gzclose
next prev parent reply other threads:[~2016-11-21 18:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-20 11:15 [PATCH] gzclose_r() and gzclose_w() are not available in older versions of zlib such as the version on Ubuntu LTS 12.04. Changing to gzclose() allows notmuch to work on older versions as well Ico Doornekamp
2016-11-21 18:28 ` David Bremner [this message]
2016-11-21 19:34 ` [PATCH] gzclose_r() and gzclose_w() are not available in older Tomi Ollila
2016-11-21 20:24 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878tscofgm.fsf@tesseract.cs.unb.ca \
--to=david@tethera.net \
--cc=ico@pruts.nl \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).