From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 189166DE128E for ; Mon, 21 Nov 2016 11:34:21 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0.527 X-Spam-Level: X-Spam-Status: No, score=0.527 tagged_above=-999 required=5 tests=[AWL=-0.125, SPF_NEUTRAL=0.652] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 84hjRIUgK5zr for ; Mon, 21 Nov 2016 11:34:18 -0800 (PST) Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) by arlo.cworth.org (Postfix) with ESMTP id 0D6AE6DE1216 for ; Mon, 21 Nov 2016 11:34:17 -0800 (PST) Received: from guru.guru-group.fi (localhost [IPv6:::1]) by guru.guru-group.fi (Postfix) with ESMTP id 78C91100086; Mon, 21 Nov 2016 21:34:56 +0200 (EET) From: Tomi Ollila To: David Bremner , Ico Doornekamp , notmuch@notmuchmail.org Subject: Re: [PATCH] gzclose_r() and gzclose_w() are not available in older... In-Reply-To: <878tscofgm.fsf@tesseract.cs.unb.ca> References: <1479640516-33847-1-git-send-email-ico@pruts.nl> <878tscofgm.fsf@tesseract.cs.unb.ca> User-Agent: Notmuch/0.23.1+52~ga6dbf3a (https://notmuchmail.org) Emacs/24.5.1 (x86_64-unknown-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Nov 2016 19:34:21 -0000 On Mon, Nov 21 2016, David Bremner wrote: > I take the submitters word for the first version supporting gzclose I tried this patch on Scientific Linux 6.2 -- after applied it I changed the check to >=3D 1.2.3 (to the one used in sl62). This compiles fine but tests fails miserably. According to http://packages.ubuntu.com/hu/source/precise/zlib it uses zlib 1.2.3.4... ... I created container based on ubuntu:12.04 ... and ... the tests fail there as bad as with 1.2.3. SO, it looks to me that (unfortunately) just doing this is not enough (knowing that one needs to test dump/restore for this patch to be feasible may not be obvious to everyone ;/). My supportive patch: id:1397809386-23356-1-git-send-email-tomi.ollila@iki.fi -- http://article.gmane.org/gmane.mail.notmuch.general/17916 still applies to many systems with older zlib versions; probably to precise as well. test output examples: Warning: cannot parse query: Eq=C3=802=C3=BDA1?=C3=A7r"9h nV)VC[=C3=A6'c=C2= =A4L=C3=94s=C2=A3eM =C7=8AV>.