From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>, Jani Nikula <jani@nikula.org>,
notmuch@notmuchmail.org
Subject: Re: [RFC PATCH 5/5] cli: add support for deduplicating based on case insensitive address
Date: Mon, 31 Aug 2015 13:52:46 +0300 [thread overview]
Message-ID: <m2oahn6875.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <874mjht1y6.fsf@maritornes.cs.unb.ca>
On Sun, Aug 30 2015, David Bremner <david@tethera.net> wrote:
> Jani Nikula <jani@nikula.org> writes:
>
>> Consider all variants of an email address as one, and print the most
>> common variant.
>
> Other than the quibbles already mentioned, the series looks ok to
> me. For production it should have one or two tests I guess. Oh, and man
> page updates. But you knew that I guess.
>
> I can live with the current argument syntax, but since a certain a mount
> of bikeshedding is expected, here is an alternative suggestion
>
> --deduplication={none|mailbox|address}
(is s/deduplicate/deduplication/ intended or accidental change?)
Is this complete alternative to --deduplicate={no|yes|address}, respectively?
If it is it looks somewhat better to me (provided that it is accurate)
anyway, the user command line interface looks good to me.
Tomi
next prev parent reply other threads:[~2015-08-31 10:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-29 14:56 [PATCH 0/5] cli: alternative address deduplication Jani Nikula
2015-08-29 14:56 ` [RFC PATCH 1/5] cli: g_hash_table_lookup_extended is overkill Jani Nikula
2015-08-29 14:56 ` [RFC PATCH 2/5] cli: abstract new mailbox creation Jani Nikula
2015-08-29 14:56 ` [RFC PATCH 3/5] cli: add support for not deduplicating notmuch address results Jani Nikula
2015-08-30 1:29 ` David Bremner
2015-08-30 7:33 ` Jani Nikula
2015-08-29 14:56 ` [RFC PATCH 4/5] cli: change the data structure for notmuch address deduplication Jani Nikula
2015-08-30 1:48 ` David Bremner
2015-08-30 7:45 ` Jani Nikula
2015-08-30 11:46 ` David Bremner
2015-08-30 7:47 ` Jani Nikula
2015-08-29 14:56 ` [RFC PATCH 5/5] cli: add support for deduplicating based on case insensitive address Jani Nikula
2015-08-30 12:06 ` David Bremner
2015-08-31 10:52 ` Tomi Ollila [this message]
2015-08-31 11:15 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2oahn6875.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=david@tethera.net \
--cc=jani@nikula.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).