unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
Subject: Re: [RFC PATCH 3/5] cli: add support for not deduplicating notmuch address results
Date: Sat, 29 Aug 2015 22:29:46 -0300	[thread overview]
Message-ID: <87d1y5tvg5.fsf@maritornes.cs.unb.ca> (raw)
In-Reply-To: <5badd1d1d46690987558dd2283efdc69be4c8c99.1440859765.git.jani@nikula.org>

Jani Nikula <jani@nikula.org> writes:


> +	{ NOTMUCH_OPT_KEYWORD, &ctx->dupe, "deduplicate", 'x',

probably you want 'D' or 'd' here. Not that it makes a practical
difference at this point.

> +	  (notmuch_keyword_t []){ { "yes", -1 },

I'm not very enthusiastic about reusing ctx->dupe for this.
In particular the use of -1 for yes is off-putting
It seems better to allocate another word of memory and use an
enum, as elsewhere.

  reply	other threads:[~2015-08-30  1:31 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-29 14:56 [PATCH 0/5] cli: alternative address deduplication Jani Nikula
2015-08-29 14:56 ` [RFC PATCH 1/5] cli: g_hash_table_lookup_extended is overkill Jani Nikula
2015-08-29 14:56 ` [RFC PATCH 2/5] cli: abstract new mailbox creation Jani Nikula
2015-08-29 14:56 ` [RFC PATCH 3/5] cli: add support for not deduplicating notmuch address results Jani Nikula
2015-08-30  1:29   ` David Bremner [this message]
2015-08-30  7:33     ` Jani Nikula
2015-08-29 14:56 ` [RFC PATCH 4/5] cli: change the data structure for notmuch address deduplication Jani Nikula
2015-08-30  1:48   ` David Bremner
2015-08-30  7:45     ` Jani Nikula
2015-08-30 11:46       ` David Bremner
2015-08-30  7:47     ` Jani Nikula
2015-08-29 14:56 ` [RFC PATCH 5/5] cli: add support for deduplicating based on case insensitive address Jani Nikula
2015-08-30 12:06   ` David Bremner
2015-08-31 10:52     ` Tomi Ollila
2015-08-31 11:15       ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d1y5tvg5.fsf@maritornes.cs.unb.ca \
    --to=david@tethera.net \
    --cc=jani@nikula.org \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).