unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>,
	David Bremner <david@tethera.net>,
	Ryan Schmidt <notmuch@ryandesign.com>,
	notmuch@notmuchmail.org
Subject: Re: [PATCH 1/3] build: move LDFLAGS after notmuch libraries.
Date: Wed, 29 Dec 2021 20:14:40 +0200	[thread overview]
Message-ID: <m2o84zjn1r.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <20211224182905.2353744-1-david@tethera.net>

On Fri, Dec 24 2021, David Bremner wrote:

> In [1] Ryan Schmidt reported a problem on macports [2] with notmuch
> finding an existing installed version of libnotmuch during the build
> when the user specified LDFLAGS including the libnotmuch install
> directory.
>
> This change should prevent that.
>
> LDFLAGS also occurs in FINAL_LIBNOTMUCH_LDFLAGS. The only built
> library linked to that is util/libtnotmuch_util.a, and that passed as
> explicit (relative) path, and is thus not affected by -L.
>
> [1]: id:7851CAB5-4556-4931-A0A2-37003E56C927@ryandesign.com
>
> [2]: The problem does not arise when libnotmuch is installed into a
> "system" library path that the compiler/linker searches by default.

This series looks good to me, and id:87lf0thhft.fsf@tethera.net
should still work.

Tomi

> ---
>  Makefile.global | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile.global b/Makefile.global
> index fe79121d..e6b00815 100644
> --- a/Makefile.global
> +++ b/Makefile.global
> @@ -52,7 +52,7 @@ PV_FILE=bindings/python/notmuch/version.py
>  # Smash together user's values with our extra values
>  FINAL_CFLAGS = -DNOTMUCH_VERSION=$(VERSION) $(CPPFLAGS) $(CFLAGS) $(WARN_CFLAGS) $(extra_cflags) $(CONFIGURE_CFLAGS)
>  FINAL_CXXFLAGS = $(CPPFLAGS) $(CXXFLAGS) $(WARN_CXXFLAGS) $(extra_cflags) $(extra_cxxflags) $(CONFIGURE_CXXFLAGS)
> -FINAL_NOTMUCH_LDFLAGS = $(LDFLAGS) -Lutil -lnotmuch_util -Llib -lnotmuch
> +FINAL_NOTMUCH_LDFLAGS = -Lutil -lnotmuch_util -Llib -lnotmuch $(LDFLAGS)
>  ifeq ($(LIBDIR_IN_LDCONFIG),0)
>  FINAL_NOTMUCH_LDFLAGS += $(RPATH_LDFLAGS)
>  endif
> -- 
> 2.34.1
>
> _______________________________________________
> notmuch mailing list -- notmuch@notmuchmail.org
> To unsubscribe send an email to notmuch-leave@notmuchmail.org

  parent reply	other threads:[~2021-12-29 18:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-17  1:08 Fix order of -I and -L flags Ryan Schmidt
2021-12-17 13:45 ` David Bremner
2021-12-20 21:21   ` Tomi Ollila
2021-12-20 22:58     ` David Bremner
2021-12-21  7:33       ` Ryan Schmidt
2021-12-24 18:29     ` [PATCH 1/3] build: move LDFLAGS after notmuch libraries David Bremner
2021-12-24 18:29       ` [PATCH 2/3] build: move CPPFLAGS after source directory includes David Bremner
2021-12-24 18:29       ` [PATCH 3/3] build: move {C,CXX}FLAGS to the end of FINAL_{C,CXX}FLAGS David Bremner
2021-12-29 18:14       ` Tomi Ollila [this message]
2021-12-31 11:12       ` [PATCH 1/3] build: move LDFLAGS after notmuch libraries David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2o84zjn1r.fsf@guru.guru-group.fi \
    --to=tomi.ollila@iki.fi \
    --cc=david@tethera.net \
    --cc=notmuch@notmuchmail.org \
    --cc=notmuch@ryandesign.com \
    --subject='Re: [PATCH 1/3] build: move LDFLAGS after notmuch libraries.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	notmuch.git.git (no URL configured)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).