From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id mOddBJqlzGEZRQEAgWs5BA (envelope-from ) for ; Wed, 29 Dec 2021 19:14:50 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id uMy/AZqlzGF9IwAA9RJhRA (envelope-from ) for ; Wed, 29 Dec 2021 19:14:50 +0100 Received: from mail.notmuchmail.org (yantan.tethera.net [135.181.149.255]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C98F034C74 for ; Wed, 29 Dec 2021 19:14:49 +0100 (CET) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 107F55F713; Wed, 29 Dec 2021 18:14:46 +0000 (UTC) Received: from lahtoruutu.iki.fi (lahtoruutu.iki.fi [185.185.170.37]) by mail.notmuchmail.org (Postfix) with ESMTPS id 968815F6DD for ; Wed, 29 Dec 2021 18:14:43 +0000 (UTC) Received: from guru.guru-group.fi (unknown [IPv6:2a02:2380:1:9:5054:ff:feb7:a4bc]) (using TLSv1.2 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: too) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id 566D91B0004B; Wed, 29 Dec 2021 20:14:42 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1640801682; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HsMU9kW22nB4t5zKXwWg0N4Rqi2Dy0Tk/ex6E33m1R4=; b=p6lt71NnfhMERWwomlE7nj17p4yZ16ic0hwzT2l8POYaLQHFp/CQONFN3BtVZRBg6HLTW5 kJU8g70sbmcgpFB9en7Klhokc5g/XwGX3bI4UTX3/4Sf67Gko44tY7AiVmKMLgfvr47MXL 3yda81zlGrK/Yc+KUHjGwwIyHmQPWRT4KzlEvN38VlT3QxaadkZ9tWSbslFk1LeiE01ZBC /cF5U2aEb2H4CMEA8Bsxpovu8FEmrJ3m5DmgQzsxEUgGLDfv5mvQ4+EmzH0vV8Rk7YYS5f R2rZMpgXTLTdPFN2+v/CfsH95FZI2uXKcUc0wHnErEsfQAyfFTa+HyACf7x2rQ== From: Tomi Ollila To: David Bremner , David Bremner , Ryan Schmidt , notmuch@notmuchmail.org Subject: Re: [PATCH 1/3] build: move LDFLAGS after notmuch libraries. In-Reply-To: <20211224182905.2353744-1-david@tethera.net> References: <20211224182905.2353744-1-david@tethera.net> User-Agent: Notmuch/0.33+54~gcaf4513 (https://notmuchmail.org) Emacs/27.1 X-Face: HhBM'cA~ MIME-Version: 1.0 ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1640801682; a=rsa-sha256; cv=none; b=R7AsSuk0GSOaGs13JsfW5eYUg4MiGDI8xAQF9g9REFxhTsWoNjqqGsfuyc/BGNKbi7iBy/ pBHEeLT9rYB3LWU3/tUV6MU6cXC3R+wWiB8c2x0OinLVzAv3PnAr5XlUPT947PSGBFB5tn 87F0VkBx34b8JvSpKiAQhU7JFNcRXUuMu7PRQMtrMou5bVPDOj+cO//Ct3fse96fY3GoQn iGpNXeVvtnbX0KX1e96KJlot1b5Ba8djJKtZ+8xIU1PCUeW8osjTV1YmozpUneZevxu/lk PZVMugfVisJKf3/5yv4baEAr+4jdyK5vRbqOTyD87ETHAwaoTcnI4bVhMoiqFQ== ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=too smtp.mailfrom=tomi.ollila@iki.fi ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1640801682; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HsMU9kW22nB4t5zKXwWg0N4Rqi2Dy0Tk/ex6E33m1R4=; b=smlbhMx8k2mgAELgyy+QDPKK8R/X6gNdY0vfaX5LYBrZSAr3o4qAoAZXpIKQfXKkrDeU0m /1k62QnoBOTqLeZgLamRbs9noKXi7OnejNkhcSf53NZtHLlI2+5A+Km+92/LEPPxCKdK+U 8ZJ7J25sVDoVoJTIv/3IFGu+e7mz5r+X0cjzQ+HuyJLMXGSgstZSZP8jr80ORJQX5+7Mbd oLPObG+q5jiVg/szH8EWlbPyv2q4Xpm6uXdoP8J5ykXEynh6S+VlF2TJ7dknQgriVGNLgu ORi91KI5yau6nzthnv78A+Xq29TVgJxoFsmAAmIXXBi4cK3zNLacbfJxG2fRVQ== Message-ID-Hash: RSEB7H2Y5C5P6QSGWWHNLMVYQ6LKDYIO X-Message-ID-Hash: RSEB7H2Y5C5P6QSGWWHNLMVYQ6LKDYIO X-MailFrom: tomi.ollila@iki.fi X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Country: DE ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1640801689; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=OUJ08u3DeISsRBRRSovEPiWtWem5xi5lWpeFmqRl3Xg=; b=fuSEB2QQImeFvUWnlI23QS1pnGXcCfjA8kuwruPBnUekeVbHv0tAiKFT5v33xME9SSpSC0 XZGq9/G5jrYQHXifubmchc1AsnA7fYxjn3TYnLfwCLW+hX5UzfV0f+8k5OHGuunwq7gwPX bVQXhkJFeT1SYl5ekcZ0p5yh5/TG8iZLiLLFdeKePVj3CBNC6S0F10p10c2B9LwQzTsIzJ 1gC0GoXjSl34XvOBosh7J/2PKgn+zlTbwn6uI+o0wS+7frpJLOAtJiCUOrmrAMgOTFwE+O kjjboqFY2K4nC4N+I7fVS2WTJJJ+0FTf0NVH/oEZVfUlzZFVSiJkOby9iZ2ZyQ== ARC-Seal: i=2; s=key1; d=yhetil.org; t=1640801689; a=rsa-sha256; cv=fail; b=rjSwg1H6ME4yw1n2aDPm0MnCvWc26M36UEx8nucyR/7fyPg4VtV+Ne7QFhpxMGNMDg5W4O eURSfnq5Z3fEQcVYGjVLbRO3Pgy1bI/kx+TP8paBu0qj2NjV6hlHbI2pNapJ3HxoiGiKTL Y4ZGCJBD5LRB7PkQQVGq0QBjT6PQtFNN+ZUeuxmAbm/sDqiEjvv5n4Jfm0fFJNDZwcDpJp H7lCcGWGDa/EMIVUPH/hY/D8Y8uMiUiVsT6MZF+J1v3dp7gtvWqXIQqJyd1JlNFFbTV69d 5QMNHgdmjrygDdLWSb3M3/73FDnnL4HaGpv1uXE9FPaCD8M+cJC8uaLgu4h4ig== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b=p6lt71Nn; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -0.35 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b=p6lt71Nn; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: C98F034C74 X-Spam-Score: -0.35 X-Migadu-Scanner: scn1.migadu.com X-TUID: /ssa5PnTQBWT On Fri, Dec 24 2021, David Bremner wrote: > In [1] Ryan Schmidt reported a problem on macports [2] with notmuch > finding an existing installed version of libnotmuch during the build > when the user specified LDFLAGS including the libnotmuch install > directory. > > This change should prevent that. > > LDFLAGS also occurs in FINAL_LIBNOTMUCH_LDFLAGS. The only built > library linked to that is util/libtnotmuch_util.a, and that passed as > explicit (relative) path, and is thus not affected by -L. > > [1]: id:7851CAB5-4556-4931-A0A2-37003E56C927@ryandesign.com > > [2]: The problem does not arise when libnotmuch is installed into a > "system" library path that the compiler/linker searches by default. This series looks good to me, and id:87lf0thhft.fsf@tethera.net should still work. Tomi > --- > Makefile.global | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile.global b/Makefile.global > index fe79121d..e6b00815 100644 > --- a/Makefile.global > +++ b/Makefile.global > @@ -52,7 +52,7 @@ PV_FILE=bindings/python/notmuch/version.py > # Smash together user's values with our extra values > FINAL_CFLAGS = -DNOTMUCH_VERSION=$(VERSION) $(CPPFLAGS) $(CFLAGS) $(WARN_CFLAGS) $(extra_cflags) $(CONFIGURE_CFLAGS) > FINAL_CXXFLAGS = $(CPPFLAGS) $(CXXFLAGS) $(WARN_CXXFLAGS) $(extra_cflags) $(extra_cxxflags) $(CONFIGURE_CXXFLAGS) > -FINAL_NOTMUCH_LDFLAGS = $(LDFLAGS) -Lutil -lnotmuch_util -Llib -lnotmuch > +FINAL_NOTMUCH_LDFLAGS = -Lutil -lnotmuch_util -Llib -lnotmuch $(LDFLAGS) > ifeq ($(LIBDIR_IN_LDCONFIG),0) > FINAL_NOTMUCH_LDFLAGS += $(RPATH_LDFLAGS) > endif > -- > 2.34.1 > > _______________________________________________ > notmuch mailing list -- notmuch@notmuchmail.org > To unsubscribe send an email to notmuch-leave@notmuchmail.org