unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Ryan Schmidt <notmuch@ryandesign.com>, notmuch@notmuchmail.org
Subject: Re: Fix order of -I and -L flags
Date: Fri, 17 Dec 2021 09:45:22 -0400	[thread overview]
Message-ID: <875yrnny4t.fsf@tethera.net> (raw)
In-Reply-To: <7851CAB5-4556-4931-A0A2-37003E56C927@ryandesign.com>

Ryan Schmidt <notmuch@ryandesign.com> writes:

> The notmuch build system puts -I and -L flags in the wrong order.
>
> Specifically, -I flags the user might specify in the CPPFLAGS
> environment variable appear before the -I flags for the project's own
> directories, resulting in build failure if a previous version of
> notmuch (whose headers differ sufficiently from the new version) was
> already installed.
>
> https://trac.macports.org/ticket/63274
>
> Similarly, -L flags the user might specify in the LDFLAGS environment
> variable appear before the -L flags for the project's own directories,
> resulting in build failure if a previous version of notmuch (whose
> libraries differ sufficiently from the new version) was already
> installed.
>
> https://trac.macports.org/ticket/63665

Although I don't consider GNU standards normative for notmuch, there is
some value in doing things a standard way. In particular the way notmuch
uses {C,CPP,LD,CXX}FLAGS follows e.g. [1].

I guess on the Linux / BSD side we expect the configure script to do the
heavy lifting so that manual setting of CPPFLAGS / LDFLAGS at build time
is not needed in general. So one question is why isn't this the case for
macports?

I think there is value in letting individual end-users use these
variables to override things (we just saw a case the other day where
that fixed someone's unique build problem). 

I'm open to ideas for how we can make things easier for macports without
taking away existing functionality for other users.

d

[1]: https://www.gnu.org/prep/standards/html_node/Command-Variables.html.

  reply	other threads:[~2021-12-17 13:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-17  1:08 Fix order of -I and -L flags Ryan Schmidt
2021-12-17 13:45 ` David Bremner [this message]
2021-12-20 21:21   ` Tomi Ollila
2021-12-20 22:58     ` David Bremner
2021-12-21  7:33       ` Ryan Schmidt
2021-12-24 18:29     ` [PATCH 1/3] build: move LDFLAGS after notmuch libraries David Bremner
2021-12-24 18:29       ` [PATCH 2/3] build: move CPPFLAGS after source directory includes David Bremner
2021-12-24 18:29       ` [PATCH 3/3] build: move {C,CXX}FLAGS to the end of FINAL_{C,CXX}FLAGS David Bremner
2021-12-29 18:14       ` [PATCH 1/3] build: move LDFLAGS after notmuch libraries Tomi Ollila
2021-12-31 11:12       ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875yrnny4t.fsf@tethera.net \
    --to=david@tethera.net \
    --cc=notmuch@notmuchmail.org \
    --cc=notmuch@ryandesign.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).