From: Tomi Ollila <tomi.ollila@iki.fi>
To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>, notmuch@notmuchmail.org
Subject: Re: test suite: FIXED messages are misordered with tests
Date: Fri, 22 May 2020 00:57:14 +0300 [thread overview]
Message-ID: <m27dx5lznp.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <87h7w9jhqp.fsf@fifthhorseman.net>
On Thu, May 21 2020, Daniel Kahn Gillmor wrote:
> On Thu 2020-05-21 00:16:48 +0300, Tomi Ollila wrote:
>> (just tested this latest works)
>
> Thanks for looking into this, Tomi!
>
> Do you have a patch to propose?
Looked a bit (now). Somewhat complicated to make perfect (enemy of good)
change.
print_test_description could be added as first line in
test_known_broken_ok_ (then inconsistent with test_known_broken_failure_)
or in test_ok_ just before calling test_known_broken_ok_
(test_known_broken_ok_ is called only once in test-lib.sh)
but it looks like test_check_missing_external_prereqs_ and
test_report_skip_ may be called before print_test_description is called
(and there may be more...)
We've accumulated quite a bit of mess during these years to the test
system, which makes it harder to do larger adjustments (and not (yet)
mentioning even larger refactorings...).
>
> --dkg
Tomi
next prev parent reply other threads:[~2020-05-21 21:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 22:03 test suite: FIXED messages are misordered with tests Daniel Kahn Gillmor
2020-05-12 23:14 ` David Bremner
2020-05-19 22:13 ` Daniel Kahn Gillmor
2020-05-20 21:04 ` Tomi Ollila
2020-05-20 21:16 ` Tomi Ollila
2020-05-21 17:54 ` Daniel Kahn Gillmor
2020-05-21 21:57 ` Tomi Ollila [this message]
2020-05-22 0:48 ` Daniel Kahn Gillmor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m27dx5lznp.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=dkg@fifthhorseman.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).