From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id OHJRIk/5xl7FEgAA0tVLHw (envelope-from ) for ; Thu, 21 May 2020 21:57:35 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id YHwFHk/5xl6DUAAAbx9fmQ (envelope-from ) for ; Thu, 21 May 2020 21:57:35 +0000 Received: from arlo.cworth.org (arlo.cworth.org [50.126.95.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DF0D19402D1 for ; Thu, 21 May 2020 21:57:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id E4AFB6DE119D; Thu, 21 May 2020 14:57:28 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qI9ER87JxTBm; Thu, 21 May 2020 14:57:28 -0700 (PDT) Received: from arlo.cworth.org (localhost [IPv6:::1]) by arlo.cworth.org (Postfix) with ESMTP id 2F6396DE1028; Thu, 21 May 2020 14:57:27 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 85F406DE1028 for ; Thu, 21 May 2020 14:57:25 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xkb7O69Wua-z for ; Thu, 21 May 2020 14:57:24 -0700 (PDT) Received: from lahtoruutu.iki.fi (lahtoruutu.iki.fi [212.16.98.55]) by arlo.cworth.org (Postfix) with ESMTPS id 628866DE0F86 for ; Thu, 21 May 2020 14:57:22 -0700 (PDT) Received: from guru.guru-group.fi (unknown [IPv6:2a02:2380:1:9:5054:ff:feb7:a4bc]) (using TLSv1.2 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: too) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id 74A091B001F0; Fri, 22 May 2020 00:57:16 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1590098236; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=//xkC5QmuYeua1ItPBGe4/X2h//GKZB8uGmN0DISq7o=; b=eQjsmR+zEdbTnIOYTj+5lcV+/MCsVsq9h2Ey3HTIBKllSmHZCMmQweykJlKjCIH9FbPHar RMI3WY0B2sjin8paCfzgRSZE5kSELcB3WsOtJk9NmHmiiSxnAWeo/VAJ4btEJRf32ZXQ04 nAneluSWfuWeg+x7czgffZhALYMgUEWWM5dE+9RwPDDt3u6qTjmWv0DBhsyPbNyjKJM+Zq c8ODYaGNh6lBWehRS+dgXtDlxskXDubXtEGYoXDYJX3zpTXIRxv0vhfEWVeZMuTd0ZIOLr Vt/s+UiWoUJ2PfkhMFDN3nvduCDcVrO/T1WsMjzqU29Ji+8jeRFKSw/3ZY2T4Q== From: Tomi Ollila To: Daniel Kahn Gillmor , notmuch@notmuchmail.org Subject: Re: test suite: FIXED messages are misordered with tests In-Reply-To: <87h7w9jhqp.fsf@fifthhorseman.net> References: <87eeron74q.fsf@fifthhorseman.net> <87h7w9jhqp.fsf@fifthhorseman.net> User-Agent: Notmuch/0.28.3+84~g41389bb (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1590098236; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=//xkC5QmuYeua1ItPBGe4/X2h//GKZB8uGmN0DISq7o=; b=I+BHhFEPFJsYH9f6FKsFAPqblrCk87GliiF0VBA1MdDsDJ+Hpa1QuOJw9kPqoLgqzhn1rr tdpJRGYfhurXyedx1UNKXifVyek1SzyRHdaNDCLzh/sZ6tUf35CNJm8UOVNtqtGMqlFTHO CAQJtjCkUjnzYk+OhTXvVVlfDcsJY2CQ4f2M1skbLr7JRaVQ85q2VTIJRJRoLb0TqOh4nb /jEYfKK8snnw/0JBcu+yTmVKRpYVp/nCx+/n3CXY3S1XsDqBw9CYNN1SFHphB+lZVxhW0K hNBVhP7MqMjtfWSU6/Q9iH0cLGN5Fl2405eDlsv2A39P3mUwsC5IW3QXat7QOg== ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1590098236; a=rsa-sha256; cv=none; b=J7UShXVxMpcR9iWgxS5sE7ECHHs0x4eYm7KyodCxq4IG+dmdcVu4zkdky0v3CH6XPGrLsZ +A324JoE8Jo3fS1FOcwoN+SbcqJ6Sk80vIDCppsv856mdptifrHZVXd/XFCFu8IpkVAg0S v+1PbChxtglnKeZLCkrKq7TKImafSHHo1FBeNJcq6ZL8E+pFfm5d0qFB58uvGECVqeINOn PutfI2cGnWBLJ+N7KvM3uCoLT7RtOqQwDWRDkloRk9612Da8UcQ21c5chg7fe7X5dyXqHF y/TC8rOrJ8Ot238C3jEWxEYFJnYj+c4Mzv1yFm6qlSNsjOP1Esrr8MpFS23NIg== ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=too smtp.mailfrom=tomi.ollila@iki.fi X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: notmuch-bounces@notmuchmail.org Sender: "notmuch" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (body hash did not verify) header.d=iki.fi header.s=lahtoruutu header.b=eQjsmR+z; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 50.126.95.6 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Spam-Score: 3.49 X-TUID: hjIUxc449WYS On Thu, May 21 2020, Daniel Kahn Gillmor wrote: > On Thu 2020-05-21 00:16:48 +0300, Tomi Ollila wrote: >> (just tested this latest works) > > Thanks for looking into this, Tomi! > > Do you have a patch to propose? Looked a bit (now). Somewhat complicated to make perfect (enemy of good) change. print_test_description could be added as first line in test_known_broken_ok_ (then inconsistent with test_known_broken_failure_) or in test_ok_ just before calling test_known_broken_ok_ (test_known_broken_ok_ is called only once in test-lib.sh) but it looks like test_check_missing_external_prereqs_ and test_report_skip_ may be called before print_test_description is called (and there may be more...) We've accumulated quite a bit of mess during these years to the test system, which makes it harder to do larger adjustments (and not (yet) mentioning even larger refactorings...). > > --dkg Tomi