From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
To: notmuch@notmuchmail.org
Subject: test suite: FIXED messages are misordered with tests
Date: Tue, 12 May 2020 18:03:17 -0400 [thread overview]
Message-ID: <87eeron74q.fsf@fifthhorseman.net> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 1402 bytes --]
I'm debugging/diagnosing/trying to clean up some "FIXED" known-broken
tests right now.
Sometimes, depending on circumstances i can't predict (race
conditions?), I see funny output like:
~~~
Use "make V=1" to see the details for passing and known broken tests.
INFO: using 2m timeout for tests
INFO: running tests with moreutils parallel
FIXED verify signed PKCS#7 subject (onepart-signed) signer User ID
T356-protected-headers: Testing Message decryption with protected headers
BROKEN confirm signed and encrypted PKCS#7 subject (sign+enc)
BROKEN confirm signed and encrypted PKCS#7 subject (sign+enc) signer User ID
BROKEN confirm signed and encrypted PKCS#7 subject (sign+enc+legacy-disp)
BROKEN confirm signed and encrypted PKCS#7 subject (sign+enc+legacy-disp) signer User ID
BROKEN confirm encryption-protected PKCS#7 subject (enc+legacy-disp)
~~~
Clearly, that FIXED should come *after* the "T356-protected-headers:"
separator.
This is a minor bug, i suppose, but i confess i don't understand the
maze of shell functions in test-lib.sh well enough to see why this is
happening, let alone to fix it.
Anyone interested in fixing it should be able to do so by marking a good
test "known broken" and then re-running the test suite. The above
output is taken from:
make -j4 check NOTMUCH_TESTS=T356-protected-headers.sh
Sorry to send a bug report with no fixes!
--dkg
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next reply other threads:[~2020-05-12 22:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 22:03 Daniel Kahn Gillmor [this message]
2020-05-12 23:14 ` test suite: FIXED messages are misordered with tests David Bremner
2020-05-19 22:13 ` Daniel Kahn Gillmor
2020-05-20 21:04 ` Tomi Ollila
2020-05-20 21:16 ` Tomi Ollila
2020-05-21 17:54 ` Daniel Kahn Gillmor
2020-05-21 21:57 ` Tomi Ollila
2020-05-22 0:48 ` Daniel Kahn Gillmor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eeron74q.fsf@fifthhorseman.net \
--to=dkg@fifthhorseman.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).