* Fwd: Delivery Status Notification (Failure) [not found] ` <5d03ff8e.1c69fb81.c82a3.d08e.GMR@mx.google.com> @ 2019-06-14 20:16 ` Tomi Ollila 2019-06-15 17:51 ` [PATCH] configure: fix mktemp call for macOS Ralph Seichter 0 siblings, 1 reply; 5+ messages in thread From: Tomi Ollila @ 2019-06-14 20:16 UTC (permalink / raw) To: notmuch [-- Attachment #1.1: Type: text/plain, Size: 2246 bytes --] Sorry for the mess -- too tired to fight with this -- hopefully the content is readable below (will not know before mail leaves...) [image: Virhekuvake] Viestiä ei toimitettu Olet lähettämässä viestiä toisesta osoitteesta tai aliaksesta Lähetysosoite-ominaisuudella. Lähetysosoite-tilin asetukset ovat virheelliset tai vanhentuneet. Tarkista kyseisen tilin asetukset ja yritä lähettää viesti uudelleen. LISÄTIETOJA <https://support.google.com/mail/?p=CustomFromDenied> ---------- Forwarded message ---------- From: Tomi Ollila <tomi.ollila@iki.fi> To: notmuch@notmuchmail.org Cc: Bcc: Date: Fri, 14 Jun 2019 23:11:47 +0300 Subject: Re: [PATCH] configure: fix mktemp call for macOS Hi cannot (easily) attach to the thread from this account, therefore... First, it would be better if TEMP_GPG=$(mktemp -d "${TMPDIR:-/tmp}/notmuch.XXXXXX") worked, then the behaviour on Linux would not change. To me it looks like the problem in that one debian bug (i847206) is that the directory pathname is already like 106 octets -- and on Linux the maximun unix domain socket pathname is 108 octets -- gpg socket is probably longer than 1 octet here :D In case of macOS (and BSD, so says internet) max pathname is 104 octets In Ralph's example $TMPDIR is /var/folders/m_/w5lk3r_1495dhnl4l0s96pr00000gn/T/ -- 50 octets. Also probably older system would not have so much longer tmpdir settings that appending gpg socket name would make length pass 104 octets... But I am not personally against "hardcoding" /tmp/ (i.e. ignoring TMPDIR) as prefix location where temporary directory for GNUPGHOME is created (and, again I don't see where it could fail (barring cases similar to xkcd workflow)), but perhaps the behavioural change could be mentioned in the commit message. (BTW: in case of clutter, by default $TMPDIR is not set, and if set then user is responsible of cleaning the clutter. if macOS does its own magic with $TMPDIR (i.e. w/o user's intervention) then os should also take care of the clutter...) (BTW2: I was about to claim that ./configure in notmuch removes GNUPGHOME quickly after its use has ended, but I did not look anything doing that...) Tomi [-- Attachment #1.2: Type: text/html, Size: 3811 bytes --] [-- Attachment #2: icon.png --] [-- Type: image/png, Size: 5747 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] configure: fix mktemp call for macOS 2019-06-14 20:16 ` Fwd: Delivery Status Notification (Failure) Tomi Ollila @ 2019-06-15 17:51 ` Ralph Seichter 2019-06-16 11:12 ` Tomi Ollila 0 siblings, 1 reply; 5+ messages in thread From: Ralph Seichter @ 2019-06-15 17:51 UTC (permalink / raw) To: notmuch * Tomi Ollila: > First, it would be better if > > TEMP_GPG=$(mktemp -d "${TMPDIR:-/tmp}/notmuch.XXXXXX") > > worked, then the behaviour on Linux would not change. I'm trying to figure out if I can override $TMPDIR during the MacPorts configure phase. According to the documentation, modifying environment variables should work, but I am not quite there yet. Corollary: I suggest we go for the method shown above for the time being. I am not a fan of hardcoding paths either. -Ralph ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] configure: fix mktemp call for macOS 2019-06-15 17:51 ` [PATCH] configure: fix mktemp call for macOS Ralph Seichter @ 2019-06-16 11:12 ` Tomi Ollila 2019-06-16 15:18 ` Ralph Seichter 0 siblings, 1 reply; 5+ messages in thread From: Tomi Ollila @ 2019-06-16 11:12 UTC (permalink / raw) To: notmuch On Sat, Jun 15 2019, Ralph Seichter wrote: > * Tomi Ollila: > >> First, it would be better if >> >> TEMP_GPG=$(mktemp -d "${TMPDIR:-/tmp}/notmuch.XXXXXX") >> >> worked, then the behaviour on Linux would not change. > > I'm trying to figure out if I can override $TMPDIR during the MacPorts > configure phase. According to the documentation, modifying environment > variables should work, but I am not quite there yet. > > Corollary: I suggest we go for the method shown above for the time > being. I am not a fan of hardcoding paths either. That maintains the status quo, so no-one needs to explain the change in commit message. SO I pre-LGTM anyone sending message containing the followin change: + if ! TEMP_GPG=$(mktemp -d "${TMPDIR:-/tmp}/notmuch.XXXXXX"); then Tomi > > -Ralph ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] configure: fix mktemp call for macOS 2019-06-16 11:12 ` Tomi Ollila @ 2019-06-16 15:18 ` Ralph Seichter 2019-06-17 5:10 ` David Bremner 0 siblings, 1 reply; 5+ messages in thread From: Ralph Seichter @ 2019-06-16 15:18 UTC (permalink / raw) To: notmuch Add missing template to mktemp, as required by macOS / OS X. Signed-off-by: Ralph Seichter <abbot@monksofcool.net> --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 8b80f0e0..6e73b22e 100755 --- a/configure +++ b/configure @@ -529,7 +529,7 @@ int main () { return 0; } EOF - if ! TEMP_GPG=$(mktemp -d); then + if ! TEMP_GPG=$(mktemp -d "${TMPDIR:-/tmp}/notmuch.XXXXXX"); then printf 'No.\nCould not make tempdir for testing session-key support.\n' errors=$((errors + 1)) elif ${CC} ${CFLAGS} ${gmime_cflags} _check_session_keys.c ${gmime_ldflags} -o _check_session_keys \ -- 2.22.0 (This obsoletes id:87r27z63uk.fsf@ra.horus-it.com) ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] configure: fix mktemp call for macOS 2019-06-16 15:18 ` Ralph Seichter @ 2019-06-17 5:10 ` David Bremner 0 siblings, 0 replies; 5+ messages in thread From: David Bremner @ 2019-06-17 5:10 UTC (permalink / raw) To: Ralph Seichter, notmuch Ralph Seichter <abbot@monksofcool.net> writes: > Add missing template to mktemp, as required by macOS / OS X. > > Signed-off-by: Ralph Seichter <abbot@monksofcool.net> > --- I've merged this to master and release. In the case that we do another point release before 0.30, it will be in that. d ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-06-17 5:10 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <CAC=HcsFwVdsxMeCLk9qZYeHbd_+qJN77EqPZ17S2UgdR0bb6mw@mail.gmail.com> [not found] ` <5d03ff8e.1c69fb81.c82a3.d08e.GMR@mx.google.com> 2019-06-14 20:16 ` Fwd: Delivery Status Notification (Failure) Tomi Ollila 2019-06-15 17:51 ` [PATCH] configure: fix mktemp call for macOS Ralph Seichter 2019-06-16 11:12 ` Tomi Ollila 2019-06-16 15:18 ` Ralph Seichter 2019-06-17 5:10 ` David Bremner
Code repositories for project(s) associated with this public inbox https://yhetil.org/notmuch.git/ This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).