From: David Bremner <david@tethera.net>
To: Tomi Ollila <tomi.ollila@iki.fi>, Tim Quelch <tim@tquelch.com>,
notmuch@notmuchmail.org
Cc: Tim Quelch <tim@tquelch.com>
Subject: Re: [PATCH] emacs: Remove notmuch-mua-message-send-hook
Date: Sat, 19 Sep 2020 06:56:04 -0300 [thread overview]
Message-ID: <87v9ga2iq3.fsf@tethera.net> (raw)
In-Reply-To: <m2zh5uc899.fsf@guru.guru-group.fi>
Tomi Ollila <tomi.ollila@iki.fi> writes:
> On Sat, Sep 12 2020, Tim Quelch wrote:
>
>> Currently `message-send-hook` functions are being called twice: In
>> notmuch send common when `notmuch-mua-send-hook` functions are
>> run (which by default includes `notmuch-mua-message-send-hook`) and in
>> `message-send` itself.
>>
>> Because `message-send-hook` functions are run in `message-send` itself,
>> we don't need also need to run them before we delegate to `message-send`
>>
>> Calling `notmuch-mua-message-send-hook` resulted in functions in
>> `message-send-hook` to be called twice. This causes bugs in
>> non-idempotent hook functions.
>
> Looks good to me. everyone who rewrote notmuch-mua-message-send-hook
> (i hope none) have to find better solution (or just...)
>
applied to master
d
prev parent reply other threads:[~2020-09-19 9:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-12 4:45 [PATCH] emacs: Remove notmuch-mua-message-send-hook Tim Quelch
2020-09-13 9:53 ` Tomi Ollila
2020-09-13 23:56 ` Tim Quelch
2020-09-19 9:56 ` David Bremner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9ga2iq3.fsf@tethera.net \
--to=david@tethera.net \
--cc=notmuch@notmuchmail.org \
--cc=tim@tquelch.com \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).