unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Tim Quelch <tim@tquelch.com>
To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: Remove notmuch-mua-message-send-hook
Date: Mon, 14 Sep 2020 09:56:33 +1000	[thread overview]
Message-ID: <87h7s144em.fsf@quelch.name> (raw)
In-Reply-To: <m2zh5uc899.fsf@guru.guru-group.fi>

> Looks good to me. everyone who rewrote notmuch-mua-message-send-hook
> (i hope none) have to find better solution (or just...)

I think that would be an incredibly small minority of people who did
that. The obvious (and easiest) customisation point has been to add a
function to `notmuch-message-send-hook` or to `message-send-hook` rather
than actually relying on overwriting or advising
`notmuch-mua-message-send-hook`


> Hmm, this is defcustom. If that (old default) is stored in 
> custom-set-variables have to remove it -- at least my  
> custom-set-variables does not reference to this hook variable, so
> most probably the effect (if any) is small...

A safer route I guess would be to just change the default value of the
hook and mark the function as obsolete.


Tim Quelch

  reply	other threads:[~2020-09-14  0:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-12  4:45 [PATCH] emacs: Remove notmuch-mua-message-send-hook Tim Quelch
2020-09-13  9:53 ` Tomi Ollila
2020-09-13 23:56   ` Tim Quelch [this message]
2020-09-19  9:56   ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h7s144em.fsf@quelch.name \
    --to=tim@tquelch.com \
    --cc=notmuch@notmuchmail.org \
    --cc=tomi.ollila@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).