From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 8KANG8fVZV+eTgAA0tVLHw (envelope-from ) for ; Sat, 19 Sep 2020 09:56:23 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id GCDtFsfVZV/+DwAAB5/wlQ (envelope-from ) for ; Sat, 19 Sep 2020 09:56:23 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (2048 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A86E094023C for ; Sat, 19 Sep 2020 09:56:19 +0000 (UTC) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 1842C29C5C; Sat, 19 Sep 2020 05:56:11 -0400 (EDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id 040DE29319 for ; Sat, 19 Sep 2020 05:56:07 -0400 (EDT) Received: by fethera.tethera.net (Postfix, from userid 1001) id 5F1335FE30; Sat, 19 Sep 2020 05:56:06 -0400 (EDT) Received: (nullmailer pid 1386321 invoked by uid 1000); Sat, 19 Sep 2020 09:56:04 -0000 From: David Bremner To: Tomi Ollila , Tim Quelch , notmuch@notmuchmail.org Subject: Re: [PATCH] emacs: Remove notmuch-mua-message-send-hook In-Reply-To: References: <20200912044540.852309-1-tim@tquelch.com> Date: Sat, 19 Sep 2020 06:56:04 -0300 Message-ID: <87v9ga2iq3.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: FQMKGPZJ22ZAMEU6BOWNM5NFZAA6S74B X-Message-ID-Hash: FQMKGPZJ22ZAMEU6BOWNM5NFZAA6S74B X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Tim Quelch X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Spam-Score: -0.97 X-TUID: P/GmEZtPj32/ Tomi Ollila writes: > On Sat, Sep 12 2020, Tim Quelch wrote: > >> Currently `message-send-hook` functions are being called twice: In >> notmuch send common when `notmuch-mua-send-hook` functions are >> run (which by default includes `notmuch-mua-message-send-hook`) and in >> `message-send` itself. >> >> Because `message-send-hook` functions are run in `message-send` itself, >> we don't need also need to run them before we delegate to `message-send` >> >> Calling `notmuch-mua-message-send-hook` resulted in functions in >> `message-send-hook` to be called twice. This causes bugs in >> non-idempotent hook functions. > > Looks good to me. everyone who rewrote notmuch-mua-message-send-hook > (i hope none) have to find better solution (or just...) > applied to master d