From: Austin Clements <amdragon@MIT.EDU>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH 2/5] test: fix insert folder: searches
Date: Fri, 24 Jan 2014 16:20:43 -0500 [thread overview]
Message-ID: <87txctm5zo.fsf@awakening.csail.mit.edu> (raw)
In-Reply-To: <7eb4b4ee3345e7b166f9dd142435da32ffeffc86.1389304779.git.jani@nikula.org>
This is the other reason I disagree with including cur/new. If we strip
it, people's existing folder: searches will mostly continue to work. If
we include it, such saved searches, scripted searches, and post-new
hooks are guaranteed to break.
On Thu, 09 Jan 2014, Jani Nikula <jani@nikula.org> wrote:
> folder: is now boolean prefix.
> ---
> test/insert | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/test/insert b/test/insert
> index e8dc4c0..4bbccd5 100755
> --- a/test/insert
> +++ b/test/insert
> @@ -126,14 +126,14 @@ test_expect_equal "$dirname" "$MAIL_DIR/new"
> test_begin_subtest "Insert message into folder"
> gen_insert_msg
> notmuch insert --folder=Drafts < "$gen_msg_filename"
> -output=$(notmuch search --output=files folder:Drafts)
> +output=$(notmuch search --output=files folder:Drafts/new)
> dirname=$(dirname "$output")
> test_expect_equal "$dirname" "$MAIL_DIR/Drafts/new"
>
> test_begin_subtest "Insert message into folder, add/remove tags"
> gen_insert_msg
> notmuch insert --folder=Drafts +draft -unread < "$gen_msg_filename"
> -output=$(notmuch search --output=messages folder:Drafts tag:draft NOT tag:unread)
> +output=$(notmuch search --output=messages folder:Drafts/cur tag:draft NOT tag:unread)
> test_expect_equal "$output" "id:$gen_msg_id"
>
> gen_insert_msg
> @@ -143,21 +143,21 @@ test_expect_code 1 "Insert message into non-existent folder" \
> test_begin_subtest "Insert message, create folder"
> gen_insert_msg
> notmuch insert --folder=F --create-folder +folder < "$gen_msg_filename"
> -output=$(notmuch search --output=files folder:F tag:folder)
> +output=$(notmuch search --output=files folder:F/new tag:folder)
> basename=$(basename "$output")
> test_expect_equal_file "$gen_msg_filename" "$MAIL_DIR/F/new/${basename}"
>
> test_begin_subtest "Insert message, create subfolder"
> gen_insert_msg
> notmuch insert --folder=F/G/H/I/J --create-folder +folder < "$gen_msg_filename"
> -output=$(notmuch search --output=files folder:F/G/H/I/J tag:folder)
> +output=$(notmuch search --output=files folder:F/G/H/I/J/new tag:folder)
> basename=$(basename "$output")
> test_expect_equal_file "$gen_msg_filename" "${MAIL_DIR}/F/G/H/I/J/new/${basename}"
>
> test_begin_subtest "Insert message, create existing subfolder"
> gen_insert_msg
> notmuch insert --folder=F/G/H/I/J --create-folder +folder < "$gen_msg_filename"
> -output=$(notmuch count folder:F/G/H/I/J tag:folder)
> +output=$(notmuch count folder:F/G/H/I/J/new tag:folder)
> test_expect_equal "$output" "2"
>
> gen_insert_msg
> --
> 1.8.5.2
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2014-01-24 21:20 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-09 22:18 [PATCH 0/5] lib: make folder: prefix literal Jani Nikula
2014-01-09 22:18 ` [PATCH 1/5] " Jani Nikula
2014-01-24 21:18 ` Austin Clements
2014-01-09 22:18 ` [PATCH 2/5] test: fix insert folder: searches Jani Nikula
2014-01-24 21:20 ` Austin Clements [this message]
2014-01-25 19:32 ` Rob Browning
2014-01-09 22:18 ` [PATCH 3/5] test: fix test for literal folder: search Jani Nikula
2014-01-09 22:18 ` [PATCH 4/5] test: add test database in format version 1 Jani Nikula
2014-01-09 22:18 ` [PATCH 5/5] test: add database upgrade test from " Jani Nikula
2014-01-24 21:17 ` [PATCH 0/5] lib: make folder: prefix literal Austin Clements
2014-01-24 23:21 ` David Bremner
2014-01-25 9:33 ` Jani Nikula
2014-01-25 10:47 ` Tomi Ollila
2014-01-25 11:06 ` Jani Nikula
2014-01-25 11:52 ` Tomi Ollila
2014-01-25 15:38 ` Jani Nikula
2014-01-25 16:58 ` David Bremner
2014-01-25 18:22 ` Jani Nikula
[not found] ` <874n4rvcvo.fsf@yoom.home.cworth.org>
2014-01-29 19:05 ` Jani Nikula
[not found] ` <87k3dir3ci.fsf@yoom.home.cworth.org>
2014-01-29 20:46 ` Austin Clements
[not found] ` <87bnyuqw60.fsf@yoom.home.cworth.org>
2014-01-30 6:34 ` Jani Nikula
2014-01-30 21:15 ` Mark Walters
2014-01-30 22:02 ` Austin Clements
2014-01-31 19:19 ` Rob Browning
2014-02-04 20:14 ` Austin Clements
2014-02-04 20:17 ` Rob Browning
2014-01-31 19:24 ` Rob Browning
2014-02-01 14:54 ` Jani Nikula
2014-02-04 20:02 ` Austin Clements
2014-02-05 13:12 ` Tomi Ollila
2014-02-05 21:12 ` Tomi Ollila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87txctm5zo.fsf@awakening.csail.mit.edu \
--to=amdragon@mit.edu \
--cc=jani@nikula.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).