From: Mark Walters <markwalters1009@gmail.com>
To: Jani Nikula <jani@nikula.org>, Carl Worth <cworth@cworth.org>,
Austin Clements <aclements@csail.mit.edu>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH 0/5] lib: make folder: prefix literal
Date: Thu, 30 Jan 2014 21:15:40 +0000 [thread overview]
Message-ID: <8761p19nnn.fsf@qmul.ac.uk> (raw)
In-Reply-To: <87a9eeou4v.fsf@nikula.org>
Dear Jani
> That is the unicorn... many of the query improvements I have in mind
> depend on a custom query parser. So I'd like to have that. And a
> pony. But in the mean time, I'm left wondering whether I should pursue
> folder: as a boolean prefix, or try to figure out if there are
> improvements to be made as a probabilistic prefix, or just put this work
> on hold. With the db upgrade and upgrade tests, it's not exactly a
> trivial amount of work.
I think a boolean prefix sounds good. As you say there are lots of
things we could do with a custom parser but I don't think its worth
delaying things like this for it.
I also think it's not worth aiming for something perfect, just "good
enough". In a bike-shedding spirit I like the suggestion above (and on
irc) of a path: prefix which is basically literal. Either ^ or a
starting / to root the folder and a terminal $ or / to fix the end.
(I don't have a preference between these: / avoids a clash with folder
name with a $ or ^ in them but $ ^ are more familiar.)
Best wishes
Mark
next prev parent reply other threads:[~2014-01-30 21:19 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-09 22:18 [PATCH 0/5] lib: make folder: prefix literal Jani Nikula
2014-01-09 22:18 ` [PATCH 1/5] " Jani Nikula
2014-01-24 21:18 ` Austin Clements
2014-01-09 22:18 ` [PATCH 2/5] test: fix insert folder: searches Jani Nikula
2014-01-24 21:20 ` Austin Clements
2014-01-25 19:32 ` Rob Browning
2014-01-09 22:18 ` [PATCH 3/5] test: fix test for literal folder: search Jani Nikula
2014-01-09 22:18 ` [PATCH 4/5] test: add test database in format version 1 Jani Nikula
2014-01-09 22:18 ` [PATCH 5/5] test: add database upgrade test from " Jani Nikula
2014-01-24 21:17 ` [PATCH 0/5] lib: make folder: prefix literal Austin Clements
2014-01-24 23:21 ` David Bremner
2014-01-25 9:33 ` Jani Nikula
2014-01-25 10:47 ` Tomi Ollila
2014-01-25 11:06 ` Jani Nikula
2014-01-25 11:52 ` Tomi Ollila
2014-01-25 15:38 ` Jani Nikula
2014-01-25 16:58 ` David Bremner
2014-01-25 18:22 ` Jani Nikula
[not found] ` <874n4rvcvo.fsf@yoom.home.cworth.org>
2014-01-29 19:05 ` Jani Nikula
[not found] ` <87k3dir3ci.fsf@yoom.home.cworth.org>
2014-01-29 20:46 ` Austin Clements
[not found] ` <87bnyuqw60.fsf@yoom.home.cworth.org>
2014-01-30 6:34 ` Jani Nikula
2014-01-30 21:15 ` Mark Walters [this message]
2014-01-30 22:02 ` Austin Clements
2014-01-31 19:19 ` Rob Browning
2014-02-04 20:14 ` Austin Clements
2014-02-04 20:17 ` Rob Browning
2014-01-31 19:24 ` Rob Browning
2014-02-01 14:54 ` Jani Nikula
2014-02-04 20:02 ` Austin Clements
2014-02-05 13:12 ` Tomi Ollila
2014-02-05 21:12 ` Tomi Ollila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8761p19nnn.fsf@qmul.ac.uk \
--to=markwalters1009@gmail.com \
--cc=aclements@csail.mit.edu \
--cc=cworth@cworth.org \
--cc=jani@nikula.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).