From: Austin Clements <amdragon@MIT.EDU>
To: Rob Browning <rlb@defaultvalue.org>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH 0/5] lib: make folder: prefix literal
Date: Tue, 4 Feb 2014 15:14:23 -0500 [thread overview]
Message-ID: <20140204201423.GP4375@mit.edu> (raw)
In-Reply-To: <871tzovu0c.fsf@trouble.defaultvalue.org>
Quoth Rob Browning on Jan 31 at 1:19 pm:
> Austin Clements <amdragon@MIT.EDU> writes:
>
> > folder: could work the way I suggested (simply the path to the file,
> > with {cur,new} stripped off).
>
> Hmm, so would notmuch try to guess whether or not it's dealing with a
> maildir++ tree, and if so convert folder:foo to a search of .foo, and/or
> folder:foo/bar to .foo.bar? Or would the user just need to know to say
> folder:.foo and folder:.foo.bar?
My opinion on this has changed over time, but I don't think we should
try to interpret Maildir++ trees specially. That is, the user would
have to say folder:.foo.bar if they're using Maildir++. The "." seems
as good as a "/" for a separator, so we might as well not translate
it. The leading "." is annoying, but *shrug* so is Maildir++.
> And if we're only planning special treatment for for maildir-like
> stores, then I wonder if the term should just be maildir:?
The simple algorithm of taking the relative path and stripping
{new,cur} (if present) does a good job of supporting both Maildir and
non-Maildir stores (while balancing this support with simplicity,
predictability, and usability).
> Though folder: would make more sense if the long-term goal was to have a
> "DTRT" term. But in that case, I wonder if it might eventually be
> expected to support mixed trees, i.e. say a tree containing maildir++
> and mh subdirs, and if so, how that should be handled.
The simple {new,cur}-stripping algorithm already does fairly well at
this. Worrying more about mixed Maildir++ and MH stores seems
unnecessary to me unless someone demonstrates and actual need.
> > many shells support "**" for recursive path matching and people are
> > already quite familiar with glob patterns for paths, so why not simply
> > adopt this?
>
> rsync too.
Ah, sure enough. Even better!
next prev parent reply other threads:[~2014-02-04 20:14 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-09 22:18 [PATCH 0/5] lib: make folder: prefix literal Jani Nikula
2014-01-09 22:18 ` [PATCH 1/5] " Jani Nikula
2014-01-24 21:18 ` Austin Clements
2014-01-09 22:18 ` [PATCH 2/5] test: fix insert folder: searches Jani Nikula
2014-01-24 21:20 ` Austin Clements
2014-01-25 19:32 ` Rob Browning
2014-01-09 22:18 ` [PATCH 3/5] test: fix test for literal folder: search Jani Nikula
2014-01-09 22:18 ` [PATCH 4/5] test: add test database in format version 1 Jani Nikula
2014-01-09 22:18 ` [PATCH 5/5] test: add database upgrade test from " Jani Nikula
2014-01-24 21:17 ` [PATCH 0/5] lib: make folder: prefix literal Austin Clements
2014-01-24 23:21 ` David Bremner
2014-01-25 9:33 ` Jani Nikula
2014-01-25 10:47 ` Tomi Ollila
2014-01-25 11:06 ` Jani Nikula
2014-01-25 11:52 ` Tomi Ollila
2014-01-25 15:38 ` Jani Nikula
2014-01-25 16:58 ` David Bremner
2014-01-25 18:22 ` Jani Nikula
[not found] ` <874n4rvcvo.fsf@yoom.home.cworth.org>
2014-01-29 19:05 ` Jani Nikula
[not found] ` <87k3dir3ci.fsf@yoom.home.cworth.org>
2014-01-29 20:46 ` Austin Clements
[not found] ` <87bnyuqw60.fsf@yoom.home.cworth.org>
2014-01-30 6:34 ` Jani Nikula
2014-01-30 21:15 ` Mark Walters
2014-01-30 22:02 ` Austin Clements
2014-01-31 19:19 ` Rob Browning
2014-02-04 20:14 ` Austin Clements [this message]
2014-02-04 20:17 ` Rob Browning
2014-01-31 19:24 ` Rob Browning
2014-02-01 14:54 ` Jani Nikula
2014-02-04 20:02 ` Austin Clements
2014-02-05 13:12 ` Tomi Ollila
2014-02-05 21:12 ` Tomi Ollila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140204201423.GP4375@mit.edu \
--to=amdragon@mit.edu \
--cc=notmuch@notmuchmail.org \
--cc=rlb@defaultvalue.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).