From: Jameson Graef Rollins <jrollins@finestructure.net>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 0/2] A bug in the exclude code
Date: Mon, 12 Mar 2012 13:03:12 -0700 [thread overview]
Message-ID: <87r4wx7fjz.fsf@servo.finestructure.net> (raw)
In-Reply-To: <1331551914-28323-1-git-send-email-markwalters1009@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1701 bytes --]
On Mon, 12 Mar 2012 11:31:52 +0000, Mark Walters <markwalters1009@gmail.com> wrote:
> There is a bug in the exclude code (found by jrollins in the
> --with-excluded series) but also present in master. None of the
> current tests were finding it so the first patch adds two tests.
Hey, Mark. Thanks so much for looking in to this. It look like this
patch fixes the issue for me too! Very excited to see this all coming
together.
> The bug (and test failure) do not appear in all configuations: on my
> main test machine (an oldish debian testing 32bit userspace with a
> 64bit kernel and xapian 1.2.7) all tests pass. On my laptop (a recent
> debian testing 64bit userspace and xapian 1.2.8) one of the new tests
> fails.
It was failing for me too, but looking closer at the test I actually
found a bug: you accidentally used the old style --no-exclude option,
instead of the new --with-excludes. When you fix the call all the tests
pass fine.
> The second patch fixes the behaviour for me but I don't see why it
> should make a difference: searches for A and not B should give the
> same results as A and not (A and B). It could be a bug in xapian, it
> could be that I am not allowed to reuse queries as I do (is query1 =
> query1 and query2 allowed?) or it could be some memory use bug on my
> part.
I can't explain it either, but there's certainly a lot about xapian that
I don't understand. Maybe one of the xapian gurus will have some ideas
(Olly? Austin?).
Anyway, thanks again for pushing on all of this, Mark.
jamie.
PS. Not a big deal, but it would have been nice for this patch set to
have been sent in-reply-to the original series it fixes, just to keep
everything together.
[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]
next prev parent reply other threads:[~2012-03-12 20:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-12 11:31 [PATCH 0/2] A bug in the exclude code Mark Walters
2012-03-12 11:31 ` [PATCH 1/2] test: add tests for message only search Mark Walters
2012-03-12 20:06 ` Jameson Graef Rollins
2012-03-12 11:31 ` [PATCH 2/2] lib: fix an exclude bug Mark Walters
2012-03-12 20:03 ` Jameson Graef Rollins [this message]
2012-03-12 21:07 ` [PATCH 0/2] A bug in the exclude code Mark Walters
2012-03-13 17:39 ` Jameson Graef Rollins
2012-03-14 2:08 ` Austin Clements
2012-03-14 11:12 ` Mark Walters
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r4wx7fjz.fsf@servo.finestructure.net \
--to=jrollins@finestructure.net \
--cc=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).