From: Mark Walters <markwalters1009@gmail.com>
To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
Subject: Re: [PATCH 0/2] A bug in the exclude code
Date: Wed, 14 Mar 2012 11:12:32 +0000 [thread overview]
Message-ID: <871uovjv1b.fsf@qmul.ac.uk> (raw)
In-Reply-To: <87mx7kndd3.fsf@awakening.csail.mit.edu>
On Tue, 13 Mar 2012 22:08:24 -0400, Austin Clements <amdragon@MIT.EDU> wrote:
> On Mon, 12 Mar 2012 11:31:52 +0000, Mark Walters <markwalters1009@gmail.com> wrote:
> > There is a bug in the exclude code (found by jrollins in the
> > --with-excluded series) but also present in master. None of the
> > current tests were finding it so the first patch adds two tests.
> >
> > The bug (and test failure) do not appear in all configuations: on my
> > main test machine (an oldish debian testing 32bit userspace with a
> > 64bit kernel and xapian 1.2.7) all tests pass. On my laptop (a recent
> > debian testing 64bit userspace and xapian 1.2.8) one of the new tests
> > fails.
> >
> > The second patch fixes the behaviour for me but I don't see why it
> > should make a difference: searches for A and not B should give the
> > same results as A and not (A and B). It could be a bug in xapian, it
> > could be that I am not allowed to reuse queries as I do (is query1 =
> > query1 and query2 allowed?) or it could be some memory use bug on my
> > part.
> >
> > Anyway the "fix" is small which should help narrow down the actual
> > cause.
>
> LGTM. Even if we don't totally understand the root cause here, this
> change is the right thing to do anyway.
>
> I think it's fine to go ahead and push this ahead of the other exclude
> updates, though obviously those will need a little rebasing on top of
> this.
Please don't push exactly this one: I will try and send a version with
a better commit message and a test that shows what is failing better
later today. (The functional part will be unchanged.)
Best wishes
Mark
prev parent reply other threads:[~2012-03-14 11:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-12 11:31 [PATCH 0/2] A bug in the exclude code Mark Walters
2012-03-12 11:31 ` [PATCH 1/2] test: add tests for message only search Mark Walters
2012-03-12 20:06 ` Jameson Graef Rollins
2012-03-12 11:31 ` [PATCH 2/2] lib: fix an exclude bug Mark Walters
2012-03-12 20:03 ` [PATCH 0/2] A bug in the exclude code Jameson Graef Rollins
2012-03-12 21:07 ` Mark Walters
2012-03-13 17:39 ` Jameson Graef Rollins
2012-03-14 2:08 ` Austin Clements
2012-03-14 11:12 ` Mark Walters [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871uovjv1b.fsf@qmul.ac.uk \
--to=markwalters1009@gmail.com \
--cc=amdragon@MIT.EDU \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).